From: Lu Baolu <baolu.lu@linux.intel.com>
To: Rolf Eike Beer <eb@emlix.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>
Cc: baolu.lu@linux.intel.com, David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Intel IOMMU: fix sysfs leak in hotplug init path
Date: Thu, 22 Apr 2021 10:46:24 +0800 [thread overview]
Message-ID: <f14bd336-bc77-bba9-05f3-3f57f34c59e3@linux.intel.com> (raw)
In-Reply-To: <1716403.SmlLz2RZUD@devpool47>
Hi Rolf,
On 4/21/21 11:12 PM, Rolf Eike Beer wrote:
> Signed-off-by: Rolf Eike Beer <eb@emlix.com>
Thanks for the patch!
Can you please adjust the subject to "iommu/vt-d: Fix sysfs leak in
alloc_domain()"? It's not only for hotplug path.
Please also add commit message.
Add below Fixes tag as well:
Fixes: 39ab9555c2411 ("iommu: Add sysfs bindings for struct iommu_device")
> ---
> drivers/iommu/intel/dmar.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> I have not actually tested this but I guess it should match the code in
> free_iommu() just below.
>
> diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
> index d5c51b5c20af..fb37a9b79b3a 100644
> --- a/drivers/iommu/intel/dmar.c
> +++ b/drivers/iommu/intel/dmar.c
> @@ -1144,7 +1144,7 @@ static int alloc_iommu(struct dmar_drhd_unit *drhd)
>
> err = iommu_device_register(&iommu->iommu);
> if (err)
> - goto err_unmap;
> + goto err_unregister;
> }
>
> drhd->iommu = iommu;
> @@ -1152,6 +1152,8 @@ static int alloc_iommu(struct dmar_drhd_unit *drhd)
>
> return 0;
>
> +err_unregister:
> + iommu_device_sysfs_remove(&iommu->iommu);
> err_unmap:
> unmap_iommu(iommu);
> error_free_seq_id:
>
Best regards,
baolu
next prev parent reply other threads:[~2021-04-22 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 15:12 [PATCH] Intel IOMMU: fix sysfs leak in hotplug init path Rolf Eike Beer
2021-04-22 2:46 ` Lu Baolu [this message]
2021-04-22 5:39 ` [PATCH] iommu/vt-d: Fix sysfs leak in alloc_domain() Rolf Eike Beer
2021-04-22 5:34 ` Lu Baolu
2021-05-21 6:53 ` Rolf Eike Beer
2021-05-21 7:02 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f14bd336-bc77-bba9-05f3-3f57f34c59e3@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=eb@emlix.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).