From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] acpi: require CRC32 to build
Date: Sun, 30 Jan 2022 14:58:13 -0800 [thread overview]
Message-ID: <f153d3dc-f4c1-9c4b-aac3-da3a696a3313@roeck-us.net> (raw)
In-Reply-To: <20220130223818.16985-1-rdunlap@infradead.org>
On 1/30/22 14:38, Randy Dunlap wrote:
> ACPI core now requires crc32() but the kernel build can fail when
> CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.
>
> Fixes this build error:
>
> ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
> include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'
>
> Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/acpi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20220128.orig/drivers/acpi/Kconfig
> +++ linux-next-20220128/drivers/acpi/Kconfig
> @@ -11,6 +11,7 @@ menuconfig ACPI
> depends on ARCH_SUPPORTS_ACPI
> select PNP
> select NLS
> + select CRC32
> default y if X86
> help
> Advanced Configuration and Power Interface (ACPI) support for
next prev parent reply other threads:[~2022-01-30 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 22:38 [PATCH] acpi: require CRC32 to build Randy Dunlap
2022-01-30 22:58 ` Guenter Roeck [this message]
2022-01-31 19:17 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f153d3dc-f4c1-9c4b-aac3-da3a696a3313@roeck-us.net \
--to=linux@roeck-us.net \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).