From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B124C433FE for ; Sun, 30 Jan 2022 22:58:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356790AbiA3W6T (ORCPT ); Sun, 30 Jan 2022 17:58:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233819AbiA3W6R (ORCPT ); Sun, 30 Jan 2022 17:58:17 -0500 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B84C061714; Sun, 30 Jan 2022 14:58:16 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id b186so17338752oif.1; Sun, 30 Jan 2022 14:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9Df74O5bzOlukfRZbmLUqfOQQ47feWvT/frNyZtSZgI=; b=Lc0MfJf7Wux1Qlf2poiJ8kmsU1LkxpOYjVBHcUPGp71pVVbX+/spyalzfLM86jGXiB YIl1g8LQJQUhnAz8n9iulARDMREIEl/EI0UCl6cwy2yDhRR8p88KNZfXZ4zL+PeLHwNv 9wF37kuBHdaVVuMfcx0ELHMkOfwSZaK0xgXCKaYmbbtIOtWZswYScY+KQ6nJGkaz/ca6 dbv4wbEITXk+zBedR2QpqljpBF+geD4lFX2XWqKkXOUqc7hgPyiyl2p1nodNUtNJNtNy +bZPrT5ohfGsEyvtIt0KaEXto7i6EYscaBQqInH7BM7vm80t6Rg9Cp/VUbxcI+UR6mw9 LPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9Df74O5bzOlukfRZbmLUqfOQQ47feWvT/frNyZtSZgI=; b=DOSAcL/mG/9bw+UTW9vpgu+DIgv2Z3KG0WXZ6Gv+BA5Pb5HZ9DWu4D9yeOgbjxzR8h cs2Nt942iNoUbxWK+KCI8DnnxFeVvET4H14ymrnm5DI6GfEZtfmUuhel29rmTthLxv2c H8vIpI/Xvzh3Jl3VefYpUROhbqFNG6KXTeZYgvwU/wgzhIxPoP28VDb2thEAgwbk8tuO /1wGTSSMwYWeecUsEkr1fVlRw/2HYhjU37Xb8+MjCh9zrKbJ6YeN2b0Oy4N70kMk8aIn 3savMyzFbJd+WUFF0zcu/cLJuKeHgBo9kqo/F7V9SFLnFtlBHxJhroUfN4iXbLQ7Ogp+ Fkqw== X-Gm-Message-State: AOAM531WXQ2HyBy3bgBUOsbCQ6NNku/wypqep7Ne6FVRZ50EhC2gFeUR PDC9DeaWNpYH9RHVvqiKYQbddtkRTRCR5Q== X-Google-Smtp-Source: ABdhPJw5qC4Lgd7HZVVI15M/HLNZloNIY++bNFPk9Sgimu3r2Ae6uDZevOfSLauiuUwwnnstCDLiQQ== X-Received: by 2002:a05:6808:189f:: with SMTP id bi31mr11430338oib.5.1643583495881; Sun, 30 Jan 2022 14:58:15 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id g4sm8070621otg.61.2022.01.30.14.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Jan 2022 14:58:15 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Sun, 30 Jan 2022 14:58:13 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] acpi: require CRC32 to build Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Cc: "Rafael J . Wysocki" , Heikki Krogerus , Linus Torvalds References: <20220130223818.16985-1-rdunlap@infradead.org> From: Guenter Roeck In-Reply-To: <20220130223818.16985-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/30/22 14:38, Randy Dunlap wrote: > ACPI core now requires crc32() but the kernel build can fail when > CRC32 is not set/enabled, so select it in the ACPI Kconfig entry. > > Fixes this build error: > > ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc': > include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le' > > Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct acpi_device") > Signed-off-by: Randy Dunlap > Reported-by: Guenter Roeck > Cc: Rafael J. Wysocki > Cc: Heikki Krogerus > Cc: Linus Torvalds Reviewed-by: Guenter Roeck Tested-by: Guenter Roeck > --- > drivers/acpi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20220128.orig/drivers/acpi/Kconfig > +++ linux-next-20220128/drivers/acpi/Kconfig > @@ -11,6 +11,7 @@ menuconfig ACPI > depends on ARCH_SUPPORTS_ACPI > select PNP > select NLS > + select CRC32 > default y if X86 > help > Advanced Configuration and Power Interface (ACPI) support for