linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>, pavel@ucw.cz
Cc: lee.jones@linaro.org, rdunlap@infradead.org,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver
Date: Tue, 21 May 2019 22:40:15 +0200	[thread overview]
Message-ID: <f16b7eb7-411a-cac4-f8ec-b34a7731166c@gmail.com> (raw)
In-Reply-To: <65c656cd-1b16-0960-fbeb-8172087b88f2@ti.com>

On 5/21/19 9:41 PM, Dan Murphy wrote:
> Jacek
> 
> On 5/21/19 1:46 PM, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 5/21/19 8:25 PM, Dan Murphy wrote:
>>> Jacek
>>>
>>> On 5/21/19 12:40 PM, Jacek Anaszewski wrote:
>>>> On 5/20/19 11:19 PM, Dan Murphy wrote:
>>>>> Jacek
>>>>>
>>>>> On 5/20/19 2:54 PM, Jacek Anaszewski wrote:
>>>>>> Hi Dan,
>>>>>>
>>>>>> On 5/7/19 10:11 PM, Dan Murphy wrote:
>>>>>>> Introduce the LM36274 LED driver.  This driver uses the ti-lmu
>>>>>>> MFD driver to probe this LED driver.  The driver configures only the
>>>>>>> LED registers and enables the outputs according to the config file.
>>>>>>>
>>>>>>> The driver utilizes the TI LMU (Lighting Management Unit) LED common
>>>>>>> framework to set the brightness bits.
>>>>>>>
>>>>>>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>>>>>>> ---
>>>>>>>      drivers/leds/Kconfig        |   7 ++
>>>>>>>      drivers/leds/Makefile       |   1 +
>>>>>>>      drivers/leds/leds-lm36274.c | 174 ++++++++++++++++++++++++++++++++++++
>>>>>>>      3 files changed, 182 insertions(+)
>>>>>>>      create mode 100644 drivers/leds/leds-lm36274.c
>>>>>>>
>>>>>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>>>>>>> index 255fdd5e8491..db83a3feca01 100644
>>>>>>> --- a/drivers/leds/Kconfig
>>>>>>> +++ b/drivers/leds/Kconfig
>>>>>>> @@ -791,6 +791,13 @@ config LEDS_LM3697
>>>>>>>            Say Y to enable the LM3697 LED driver for TI LMU devices.
>>>>>>>            This supports the LED device LM3697.
>>>>>>>      +config LEDS_LM36274
>>>>>>> +    tristate "LED driver for LM36274"
>>>>>>> +    depends on LEDS_TI_LMU_COMMON
>>>>>>
>>>>>> Shouldn't we have "depends on MFD_TI_LMU" as well here?
>>>>>>
>>>>>
>>>>> Actually the LEDS_TI_LMU_COMMON flag should depend on MFD_TI_LMU.
>>>>> Then it would inherit that dependency.
>>>>
>>>> LEDS_TI_LMU_COMMON does not seem too have any dependency on MFD_TI_LMU,
>>>> and it would be incorrect to require enabling MFD_TI_LMU for all drivers
>>>> depending on TI_LMU_COMMON, that can be probed on their own, like
>>>> leds-lm3697.c .
>>>>
>>>
>>> Correct.
>>>
>>> I can update the Kconfigs unless you want to ammend the commits.
>>
>> I added "depends on MFD_TI_LMU" to "config LEDS_LM36274".
>> Please verify your patch sets pushed to [0].
>>
> 
> Pulled
> Built
> tested
> verified
> 
> Good to go
Thanks! Merged.

-- 
Best regards,
Jacek Anaszewski

  reply	other threads:[~2019-05-21 20:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 20:11 [PATCH v4 0/6] LM36274 Introduction Dan Murphy
2019-05-07 20:11 ` [PATCH v4 1/6] regulator: lm363x: Make the gpio register enable flexible Dan Murphy
2019-05-07 20:11 ` [PATCH v4 2/6] dt-bindings: mfd: Add lm36274 bindings to ti-lmu Dan Murphy
2019-05-08 11:52   ` Lee Jones
2019-05-07 20:11 ` [PATCH v4 3/6] mfd: ti-lmu: Add LM36274 support to the ti-lmu Dan Murphy
2019-05-08 11:53   ` Lee Jones
2019-05-07 20:11 ` [PATCH v4 4/6] regulator: lm363x: Add support for LM36274 Dan Murphy
2019-05-07 20:11 ` [PATCH v4 5/6] dt-bindings: leds: Add LED bindings for the LM36274 Dan Murphy
2019-05-07 20:11 ` [PATCH v4 6/6] leds: lm36274: Introduce the TI LM36274 LED driver Dan Murphy
2019-05-20 19:54   ` Jacek Anaszewski
2019-05-20 21:19     ` Dan Murphy
2019-05-21 17:40       ` Jacek Anaszewski
2019-05-21 18:25         ` Dan Murphy
2019-05-21 18:46           ` Jacek Anaszewski
2019-05-21 19:41             ` Dan Murphy
2019-05-21 20:40               ` Jacek Anaszewski [this message]
2019-05-14 19:11 ` [PATCH v4 0/6] LM36274 Introduction Jacek Anaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f16b7eb7-411a-cac4-f8ec-b34a7731166c@gmail.com \
    --to=jacek.anaszewski@gmail.com \
    --cc=dmurphy@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).