From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2FBC636CC for ; Mon, 13 Feb 2023 11:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229975AbjBMLAN (ORCPT ); Mon, 13 Feb 2023 06:00:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjBMLAL (ORCPT ); Mon, 13 Feb 2023 06:00:11 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E9F7BDC7 for ; Mon, 13 Feb 2023 03:00:10 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id bu23so11712297wrb.8 for ; Mon, 13 Feb 2023 03:00:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c2OREUNkDHFo+6N4ZDHlsRxITrcEyLw+kVy88yhDDyg=; b=bLYM6lVB6hoCsp0byzoA0iR72BM+YJVLDs6Nu4sZLAVLA1pPuYwCJV8ecUJQIoR+8P u76I2Z1jSi5uzQIX5yjPAKAGvBql3yAlnYXPbTnWlGMknTpgcSYMs3MR4/v6uOtpCZrm GS9XdUVWWvdzk83i5f3svEgoqndpoVNtVNm7Klf8FcAWt+9ItdaWtQvyHfM2HdRavRr9 nCNaByxSrKsHAM770HAQLfAhtooM3/1sQfAUqEqW+UmJXInJvAMNhVXimCyMr1UsSxao NLd/4fHTDEIH3jbvW84cpuFFq3AjiWbJ8frIF4CWHfMRP/ovJQvSmXlMkb8FOK3+eEw7 jEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c2OREUNkDHFo+6N4ZDHlsRxITrcEyLw+kVy88yhDDyg=; b=F7H/s7Ty8L1ZEcCeU1w5m/9RBf66EAWhPBREpas4jpO4Uqm4E/fiXAUEom/5aZ6qRE 5c6qDs+cL83cJUa360wkXid8tfp0BzK0R9YcH9PFUPt5+tkZ/4txYYtmRNcjXhoAx0Er 84F5rSYj/gS/ddH6+FZjgpE+0iZT+1EjbJyAJ+lWSHTrY0XlUWvPjTsrSX6CuhVlCvHE yiPOiS25+BVkxhoKJQRaD8cGJfliZc6iCF3QD0EJQzr/rS6eO4EzDhB0eqkGqcUOQl8+ 4g/5shQ4NeJeYkZg2LT2B648XwYL5RjnnOQyNVJsnnbLI7xCWwB19Xlj62NuCo/e9Ga3 QQ/g== X-Gm-Message-State: AO0yUKV1u7ktOtb/CS3+rdZzuBEDGK91La1OSIymt3oIXba1Ba1u3A1X ogKLcbgdHzDWxaMz0e0IAyDr4g== X-Google-Smtp-Source: AK7set8Az8lflKGGAyVJoMUwWTvPJZXQy3tXG76vQT2n6km1ji7E3RkIzXnJ3v/QjTWCBlEoeoqdzw== X-Received: by 2002:a05:6000:1d2:b0:2bf:b661:87d9 with SMTP id t18-20020a05600001d200b002bfb66187d9mr19780548wrx.50.1676286009033; Mon, 13 Feb 2023 03:00:09 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id g17-20020a056000119100b002c54e26bca5sm5790579wrx.49.2023.02.13.03.00.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 03:00:08 -0800 (PST) Message-ID: Date: Mon, 13 Feb 2023 12:00:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 6/6] dt-bindings: soc: amlogic: update sysctrl clock-controller subnode type Content-Language: en-US To: Neil Armstrong , Alessandro Zummo , Alexandre Belloni , Rob Herring , Krzysztof Kozlowski , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Michael Turquette , Stephen Boyd Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org References: <20230209-b4-amlogic-bindings-convert-take2-v1-0-c4fe9049def9@linaro.org> <20230209-b4-amlogic-bindings-convert-take2-v1-6-c4fe9049def9@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230209-b4-amlogic-bindings-convert-take2-v1-6-c4fe9049def9@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2023 14:41, Neil Armstrong wrote: > Since the clock controllers are now documented define the right ref > for the clock-controller subnodes and fill up the example node. > > Signed-off-by: Neil Armstrong > --- > .../soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > index 672eabd90c09..57eae355f1b9 100644 > --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-hhi-sysctrl.yaml > @@ -43,6 +43,10 @@ allOf: > - amlogic,meson-gx-hhi-sysctrl > - amlogic,meson-axg-hhi-sysctrl > then: > + properties: > + clock-controller: > + $ref: /schemas/clock/amlogic,gxbb-clkc.yaml# You just added this binding. I don't understand the split. > + > required: > - power-controller > > @@ -53,6 +57,10 @@ allOf: > - amlogic,meson-gx-ao-sysctrl > - amlogic,meson-axg-ao-sysctrl > then: > + properties: > + clock-controller: > + $ref: /schemas/clock/amlogic,gxbb-aoclkc.yaml# > + > required: > - pinctrl > > @@ -81,7 +89,12 @@ examples: > compatible = "amlogic,meson-gx-hhi-sysctrl", "simple-mfd", "syscon"; > reg = <0 0x400>; > > - clock-controller { }; > + clock-controller { > + compatible = "amlogic,gxbb-clkc"; > + #clock-cells = <1>; > + clocks = <&xtal>; > + clock-names = "xtal"; Best regards, Krzysztof