From: Florian Fainelli <f.fainelli@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
robh+dt@kernel.org, peppe.cavallaro@st.com,
alexandre.torgue@st.com, andrew@lunn.ch
Subject: Re: [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type
Date: Fri, 20 Sep 2019 20:02:58 -0700 [thread overview]
Message-ID: <f189cdbc-b399-7700-a39a-ba185df4af49@gmail.com> (raw)
In-Reply-To: <20190920181141.52cfee67@cakuba.netronome.com>
On 9/20/2019 6:11 PM, Jakub Kicinski wrote:
> On Tue, 17 Sep 2019 13:30:52 +0300, Alexandru Ardelean wrote:
>> The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type',
>> which are enums of mode strings.
>>
>> The 'dwmac' driver supports almost all modes declared in the 'phy-mode'
>> enum (except for 1 or 2). But in general, there may be a case where
>> 'mac-mode' becomes more generic and is moved as part of phylib or netdev.
>>
>> In any case, the 'mac-mode' field should be made an enum, and it also makes
>> sense to just reference the 'phy-connection-type' from
>> 'ethernet-controller.yaml'. That will also make it more future-proof for new
>> modes.
>>
>> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> Applied, thank you!
>
> FWIW I had to add the Fixes tag by hand, either ozlabs patchwork or my
> git-pw doesn't have the automagic handling there, yet.
AFAICT the ozlabs patchwork instance does not do it, but if you have
patchwork administrative rights (the jango administration panel I mean)
then it is simple to add the regular expression to the list of tags that
patchwork already recognized. Had tried getting that included by
default, but it also counted all of those tags and therefore was not
particularly fine grained:
https://lists.ozlabs.org/pipermail/patchwork/2017-January/003910.html
--
Florian
next prev parent reply other threads:[~2019-09-21 3:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 10:30 [PATCH] dt-bindings: net: dwmac: fix 'mac-mode' type Alexandru Ardelean
2019-09-17 12:41 ` Andrew Lunn
2019-09-17 13:24 ` Ardelean, Alexandru
2019-09-17 13:53 ` Rob Herring
2019-09-21 1:11 ` Jakub Kicinski
2019-09-21 3:02 ` Florian Fainelli [this message]
2019-09-21 18:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f189cdbc-b399-7700-a39a-ba185df4af49@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=alexandru.ardelean@analog.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).