From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbdBULUY (ORCPT ); Tue, 21 Feb 2017 06:20:24 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:36622 "EHLO outils.crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbdBULUQ (ORCPT ); Tue, 21 Feb 2017 06:20:16 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 21 Feb 2017 12:20:10 +0100 From: Paul Cercueil To: Linus Walleij Cc: Rob Herring , Mark Rutland , Ralf Baechle , Ulf Hansson , Boris Brezillon , Thierry Reding , Bartlomiej Zolnierkiewicz , Maarten ter Huurne , Lars-Peter Clausen , Paul Burton , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linux MIPS , linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, James Hogan Subject: Re: [PATCH v3 01/14] Documentation: dt/bindings: Document pinctrl-ingenic In-Reply-To: References: <27071da2f01d48141e8ac3dfaa13255d@mail.crapouillou.net> <20170125185207.23902-1-paul@crapouillou.net> <20170125185207.23902-2-paul@crapouillou.net> <20170130203617.hpljtcmzava3rq2n@rob-hp-laptop> <12dc62a7255bd453ff4e5e89f93ebc58@mail.crapouillou.net> Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 2017-02-20 14:56, Linus Walleij a écrit : > On Thu, Feb 9, 2017 at 6:28 PM, Paul Cercueil > wrote: > >> I was thinking that instead of having one pinctrl-ingenic instance >> covering >> 0x600 of register space, and 6 instances of gpio-ingenic having 0x100 >> each, >> I could just have 6 instances of pinctrl-ingenic, each one with an >> instance >> of gpio-ingenic declared as a sub-node, each handling just 0x100 of >> memory >> space. > > My head is spinning, but I think I get it. What is wrong with the > solution > I proposed with one pin control instance covering the whole 0x600 and > with 6 > subnodes of GPIO? > > The GPIO nodes do not even have to have an address range associated > with > them you know, that can be distributed out with regmap code accessing > the parent regmap. OK, but then each GPIO chip 'X' still need to know its offset in the register area, which is (pinctrl_base + X * 0x100). What's the best way to pass that info to the driver? (I assume it's not with a custom DT binding...). Regards, -Paul