clk: keystone: Clarification for a return value check in _of_pll_clk_init()

* clk: keystone: Clarification for a return value check in _of_pll_clk_init()
@ 2020-05-02 16:48 Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-02 16:48 UTC (permalink / raw)
  To: linux-clk, Michael Turquette, Santosh Shilimkar, Stephen Boyd
  Cc: LKML, kernel-janitors

Hello,

I have tried another small script out for the semantic patch language.
This source code analysis approach points out that the function “clk_register_pll”
is called by the function “_of_pll_clk_init”.
https://elixir.bootlin.com/linux/v5.7-rc3/source/drivers/clk/keystone/pll.c#L153
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/keystone/pll.c?id=690e2aba7beb1ef06352803bea41a68a3c695015#n153

A null pointer check is performed at this place.
The function “clk_register_pll” (from the same source file) can eventually
return the pointer “ERR_PTR(-ENOMEM)”.
Is there a need to take this special case also into account?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread