From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842AbdFFMEX (ORCPT ); Tue, 6 Jun 2017 08:04:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:45392 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751390AbdFFMEW (ORCPT ); Tue, 6 Jun 2017 08:04:22 -0400 Subject: Re: [PATCH v4 3/8] nvmet: implement namespace identify descriptor list To: Christoph Hellwig Cc: Sagi Grimberg , Keith Busch , Hannes Reinecke , maxg@mellanox.com, Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20170604103649.22130-1-jthumshirn@suse.de> <20170604103649.22130-4-jthumshirn@suse.de> <20170605053545.GD19480@lst.de> From: Johannes Thumshirn Message-ID: Date: Tue, 6 Jun 2017 14:04:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170605053545.GD19480@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2017 07:35 AM, Christoph Hellwig wrote: > I think this needs to zero the remainder of the 4k > buffer, quoting the spec: *gah* yeah, my initial version with the kzalloc() took care of it. > It could be easily done by copying the zero page to userspace. > Eventually I want to add a helper to zero parts of a sglist to > lib/scatterlist.c, but I don't want to burden that on you. I'll have a look. -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850