From: Steven Price <steven.price@arm.com>
To: Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
open list <linux-kernel@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Thomas Zimmermann <tzimmermann@suse.de>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 03/11] drm/shmem: drop VM_DONTDUMP
Date: Mon, 23 Sep 2019 14:32:32 +0100 [thread overview]
Message-ID: <f1bd2517-f49f-34c0-6b75-3181c4698f60@arm.com> (raw)
In-Reply-To: <20190917092404.9982-4-kraxel@redhat.com>
On 17/09/2019 10:23, Gerd Hoffmann wrote:
> Not obvious why this is needed. According to Deniel Vetter this is most
> likely a historic artefact dating back to the days where drm drivers
> exposed hardware registers as mmap'able gem objects, to avoid dumping
> touching those registers. shmem gem objects surely don't need that ...
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index a9a586630517..6efedab15016 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -536,7 +536,7 @@ int drm_gem_shmem_mmap(struct drm_gem_object *obj, struct vm_area_struct *vma)
> return ret;
> }
>
> - vma->vm_flags |= VM_IO | VM_MIXEDMAP | VM_DONTEXPAND | VM_DONTDUMP;
> + vma->vm_flags |= VM_IO | VM_MIXEDMAP | VM_DONTEXPAND;
> vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags));
> vma->vm_page_prot = pgprot_decrypted(vma->vm_page_prot);
> vma->vm_ops = &drm_gem_shmem_vm_ops;
>
next prev parent reply other threads:[~2019-09-23 13:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190917092404.9982-1-kraxel@redhat.com>
2019-09-17 9:23 ` [PATCH v2 01/11] drm: add mmap() to drm_gem_object_funcs Gerd Hoffmann
2019-09-17 9:23 ` [PATCH v2 02/11] drm/shmem: switch shmem helper to &drm_gem_object_funcs.mmap Gerd Hoffmann
2019-09-23 13:29 ` Steven Price
2019-09-17 9:23 ` [PATCH v2 03/11] drm/shmem: drop VM_DONTDUMP Gerd Hoffmann
2019-09-23 13:32 ` Steven Price [this message]
2019-09-17 9:23 ` [PATCH v2 04/11] drm/shmem: drop VM_IO Gerd Hoffmann
2019-09-23 13:32 ` Steven Price
2019-09-17 9:23 ` [PATCH v2 05/11] drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS Gerd Hoffmann
2019-09-17 9:23 ` [PATCH v2 06/11] drm/ttm: factor out ttm_bo_mmap_vma_setup Gerd Hoffmann
2019-09-17 9:24 ` [PATCH v2 07/11] drm/ttm: drop VM_DONTDUMP Gerd Hoffmann
2019-09-17 11:22 ` Koenig, Christian
2019-09-17 11:40 ` Gerd Hoffmann
2019-09-17 9:24 ` [PATCH v2 08/11] drm/ttm: add drm_gem_ttm_mmap() Gerd Hoffmann
2019-09-17 9:24 ` [PATCH v2 09/11] drm/vram: switch vram helper to &drm_gem_object_funcs.mmap() Gerd Hoffmann
2019-09-17 9:24 ` [PATCH v2 10/11] drm/vram: drop verify_access Gerd Hoffmann
2019-09-17 9:24 ` [PATCH v2 11/11] drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1bd2517-f49f-34c0-6b75-3181c4698f60@arm.com \
--to=steven.price@arm.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).