From: Jens Axboe <axboe@kernel.dk>
To: Dennis Zhou <dennis@kernel.org>
Cc: kernel-team@fb.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blkcg: add rcu lock to bio_clone_blkg_association()
Date: Fri, 21 Dec 2018 08:26:02 -0700 [thread overview]
Message-ID: <f1dacd9e-7c3d-44e5-aff1-923d9e7a374c@kernel.dk> (raw)
In-Reply-To: <20181221145441.13814-1-dennis@kernel.org>
On 12/21/18 7:54 AM, Dennis Zhou wrote:
> I cleaned up blkg_tryget_closest() to require rcu_read_lock() earlier.
> However, this was a subtle case too which clearly was too subtle for me.
> The idea was the src bio should be holding a ref to the blkg so rcu
> wasn't technically needed. If it doesn't hold a ref, it should be %NULL
> and the blkg->parent pointers are unused.
>
> This adds the appropriate read lock in bio_clone_blkg_association().
Shall I just fold this with the previous? I staged it in a
later-in-merge-cycle branch, so that's not an issue to amend.
--
Jens Axboe
next prev parent reply other threads:[~2018-12-21 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 14:54 [PATCH] blkcg: add rcu lock to bio_clone_blkg_association() Dennis Zhou
2018-12-21 15:26 ` Jens Axboe [this message]
2018-12-21 17:02 ` Dennis Zhou
2018-12-21 17:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1dacd9e-7c3d-44e5-aff1-923d9e7a374c@kernel.dk \
--to=axboe@kernel.dk \
--cc=dennis@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).