From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Thomas Hellstrom <thellstrom@vmware.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Linux-graphics-maintainer <Linux-graphics-maintainer@vmware.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/9] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct
Date: Sat, 13 Apr 2019 18:39:59 +0000 [thread overview]
Message-ID: <f1ddc6a4-7992-2edd-2b2c-de3e8d573e4d@amd.com> (raw)
In-Reply-To: <20190412160338.64994-5-thellstrom@vmware.com>
Am 12.04.19 um 18:04 schrieb Thomas Hellstrom:
> Add a pointer to the struct vm_operations_struct in the bo_device, and
> assign that pointer to the default value currently used.
>
> The driver can then optionally modify that pointer and the new value
> can be used for each new vma created.
>
> Cc: "Christian König" <christian.koenig@amd.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Yes, please. This way we can also finally cleanup the VM operations hack
we use in radeon and maybe still even amdgpu.
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 1 +
> drivers/gpu/drm/ttm/ttm_bo_vm.c | 6 +++---
> include/drm/ttm/ttm_bo_driver.h | 6 ++++++
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 3f56647cdb35..1c85bec00472 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1656,6 +1656,7 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev,
> mutex_lock(&ttm_global_mutex);
> list_add_tail(&bdev->device_list, &glob->device_list);
> mutex_unlock(&ttm_global_mutex);
> + bdev->vm_ops = &ttm_bo_vm_ops;
>
> return 0;
> out_no_sys:
> diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c
> index e86a29a1e51f..bfb25b81fed7 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c
> @@ -395,7 +395,7 @@ static int ttm_bo_vm_access(struct vm_area_struct *vma, unsigned long addr,
> return ret;
> }
>
> -static const struct vm_operations_struct ttm_bo_vm_ops = {
> +const struct vm_operations_struct ttm_bo_vm_ops = {
> .fault = ttm_bo_vm_fault,
> .open = ttm_bo_vm_open,
> .close = ttm_bo_vm_close,
> @@ -445,7 +445,7 @@ int ttm_bo_mmap(struct file *filp, struct vm_area_struct *vma,
> if (unlikely(ret != 0))
> goto out_unref;
>
> - vma->vm_ops = &ttm_bo_vm_ops;
> + vma->vm_ops = bdev->vm_ops;
>
> /*
> * Note: We're transferring the bo reference to
> @@ -477,7 +477,7 @@ int ttm_fbdev_mmap(struct vm_area_struct *vma, struct ttm_buffer_object *bo)
>
> ttm_bo_get(bo);
>
> - vma->vm_ops = &ttm_bo_vm_ops;
> + vma->vm_ops = bo->bdev->vm_ops;
> vma->vm_private_data = bo;
> vma->vm_flags |= VM_MIXEDMAP;
> vma->vm_flags |= VM_IO | VM_DONTEXPAND;
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index cbf3180cb612..cfeaff5d9706 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -443,6 +443,9 @@ extern struct ttm_bo_global {
> * @driver: Pointer to a struct ttm_bo_driver struct setup by the driver.
> * @man: An array of mem_type_managers.
> * @vma_manager: Address space manager
> + * @vm_ops: Pointer to the struct vm_operations_struct used for this
> + * device's VM operations. The driver may override this before the first
> + * mmap() call.
> * lru_lock: Spinlock that protects the buffer+device lru lists and
> * ddestroy lists.
> * @dev_mapping: A pointer to the struct address_space representing the
> @@ -461,6 +464,7 @@ struct ttm_bo_device {
> struct ttm_bo_global *glob;
> struct ttm_bo_driver *driver;
> struct ttm_mem_type_manager man[TTM_NUM_MEM_TYPES];
> + const struct vm_operations_struct *vm_ops;
>
> /*
> * Protected by internal locks.
> @@ -489,6 +493,8 @@ struct ttm_bo_device {
> bool no_retry;
> };
>
> +extern const struct vm_operations_struct ttm_bo_vm_ops;
> +
> /**
> * struct ttm_lru_bulk_move_pos
> *
next prev parent reply other threads:[~2019-04-13 18:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 16:04 [PATCH 0/9] Emulated coherent graphics memory Thomas Hellstrom
2019-04-12 16:04 ` [PATCH 1/9] mm: Allow the [page|pfn]_mkwrite callbacks to drop the mmap_sem Thomas Hellstrom
2019-04-12 18:52 ` Ralph Campbell
2019-04-13 15:11 ` Souptick Joarder
2019-04-17 10:58 ` Thomas Hellstrom
2019-04-17 13:00 ` Souptick Joarder
2019-04-12 16:04 ` [PATCH 2/9] mm: Add an apply_to_pfn_range interface Thomas Hellstrom
2019-04-12 18:52 ` Ralph Campbell
2019-04-12 21:07 ` Jerome Glisse
2019-04-13 8:34 ` Thomas Hellstrom
2019-04-16 14:46 ` Jerome Glisse
2019-04-17 9:15 ` Thomas Hellstrom
2019-04-17 14:28 ` Jerome Glisse
2019-04-12 16:04 ` [PATCH 3/9] mm: Add write-protect and clean utilities for address space ranges Thomas Hellstrom
2019-04-12 18:52 ` Ralph Campbell
2019-04-13 8:40 ` Thomas Hellstrom
2019-04-12 16:04 ` [PATCH 4/9] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct Thomas Hellstrom
2019-04-13 18:39 ` Koenig, Christian [this message]
2019-04-12 16:04 ` [PATCH 5/9] drm/ttm: TTM fault handler helpers Thomas Hellstrom
2019-04-15 6:34 ` Christian König
2019-04-17 10:53 ` Thomas Hellstrom
2019-04-12 16:04 ` [PATCH 6/9] drm/vmwgfx: Implement an infrastructure for write-coherent resources Thomas Hellstrom
2019-04-22 18:54 ` Deepak Singh Rawat
2019-04-24 9:10 ` Thomas Hellstrom
2019-04-12 16:04 ` [PATCH 7/9] drm/vmwgfx: Use an RBtree instead of linked list for MOB resources Thomas Hellstrom
2019-04-22 19:15 ` Deepak Singh Rawat
2019-04-12 16:04 ` [PATCH 8/9] drm/vmwgfx: Implement an infrastructure for read-coherent resources Thomas Hellstrom
2019-04-22 20:12 ` Deepak Singh Rawat
2019-04-24 9:26 ` Thomas Hellstrom
2019-04-12 16:04 ` [PATCH 9/9] drm/vmwgfx: Add surface dirty-tracking callbacks Thomas Hellstrom
2019-04-23 2:51 ` Deepak Singh Rawat
2019-04-24 12:00 [PATCH 0/9] Emulated coherent graphics memory v2 Thomas Hellstrom
2019-04-24 12:00 ` [PATCH 4/9] drm/ttm: Allow the driver to provide the ttm struct vm_operations_struct Thomas Hellstrom
2019-04-24 14:10 ` Koenig, Christian
2019-04-24 14:20 ` Thomas Hellstrom
2019-04-25 8:35 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ddc6a4-7992-2edd-2b2c-de3e8d573e4d@amd.com \
--to=christian.koenig@amd.com \
--cc=Linux-graphics-maintainer@vmware.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).