From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932583AbdK2MjY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 29 Nov 2017 07:39:24 -0500
Received: from mga07.intel.com ([134.134.136.100]:25522 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932569AbdK2MjX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 29 Nov 2017 07:39:23 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,473,1505804400"; 
   d="scan'208";a="1249872049"
Subject: Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling
 with IRQ state tracing enabled
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>
References: <0fede9f9-88b0-a6e7-1027-dfb2019b8ef2@linux.intel.com>
 <20171129070951.hjjjpbyilzaak4ig@gmail.com>
 <17b6e0c8-db18-f63d-0118-52b85c0c2a7f@linux.intel.com>
 <alpine.DEB.2.20.1711291027450.1825@nanos>
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Message-ID: <f1ea2772-c4fa-8b74-f6fb-04e5d2eeb38a@linux.intel.com>
Date: Wed, 29 Nov 2017 14:39:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1711291027450.1825@nanos>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/2017 11:28 AM, Thomas Gleixner wrote:
> On Wed, 29 Nov 2017, Jarkko Nikula wrote:
> 
>> On 11/29/2017 09:09 AM, Ingo Molnar wrote:
>>> Hm, that commit looks broken with irq-tracing enabled. Does the
>>> patch below fix it?
>>>
>> No, it makes the machine not to boot at all :-(
>>
>> Log below when I used my config (now attached). With x86_64_defconfig it
>> booted twice but didn't survive suspend/resume. However several other boot
>> attempts with x86_64_defconfig failed somewhat similarly. Not in the same
>> place but hanging anyway. With my own config it seems to always end up failing
>> in trace_hardirqs_off_caller.
> 
> Does it work when you disable all the tracing muck?
> 
My config seems to work with Ingo's patch if I disable both 
CONFIG_FTRACE and CONFIG_PROVE_LOCKING which disables the 
CONFIG_TRACE_IRQS_FLAGS.

x86_64_defconfig with CONFIG_FTRACE disabled is still unstable. 
Sometimes hangs during bootup and sometimes boots up to userspace.

-- 
Jarkko