linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: m18063 <Claudiu.Beznea@microchip.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Baruch Siach <baruch@tkos.co.il>
Cc: <nicolas.ferre@microchip.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <linux@armlinux.org.uk>, <sza@esh.hu>,
	<devicetree@vger.kernel.org>, <cristian.birsan@microchip.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support
Date: Fri, 30 Jun 2017 15:28:51 +0300	[thread overview]
Message-ID: <f204f169-1939-31cc-05af-8a715b86e082@microchip.com> (raw)
In-Reply-To: <20170629121655.37pq7cnabvv4wh7z@piout.net>

Hi Baruch, Alexandre

On 29.06.2017 15:16, Alexandre Belloni wrote:
> On 29/06/2017 at 14:59:31 +0300, Baruch Siach wrote:
>> Hi Claudiu,
>>
>> On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote:
>>> Add specifig DTS files and bindings for sama5d27 SoM1 EK board.
>>
>> Is there any publicly available information on this SoM?
>>
>> One more comment below.
>>
>>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>>> Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
>>> ---
>>
>> [snip]
>>
>>> +	memory {
>>> +		reg = <0x20000000 0x20000>;
>>
>> Are you sure this SoM has 132KB RAM?
Yes, here is a mistake, the size is 128MB. Sorry for the noise.
>>
>> Since you seem to rely on the bootloader to fill in the right size value, you 
>> can just drop this node and rely on sama5d2.dtsi that provides a stub node.
>>
> 
> Yeah, that is what I would do too.
Ok, I will do it so in v2.

Thank you,
Claudiu
> 
> 

  reply	other threads:[~2017-06-30 12:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 11:44 [PATCH 0/5] Add SoM1 support Claudiu Beznea
2017-06-29 11:44 ` [PATCH 1/5] ARM: dts: at91: sama5d2: add QSPI nodes Claudiu Beznea
2017-06-29 11:44 ` [PATCH 2/5] ARM: dts: at91: sama5d2: add isc node Claudiu Beznea
2017-06-29 11:44 ` [PATCH 3/5] drivers: soc: atmel: Add basic support for new sama5d2 SiPs Claudiu Beznea
2017-06-29 11:44 ` [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support Claudiu Beznea
2017-06-29 14:58   ` Ludovic Desroches
2017-06-30 12:38     ` m18063
2017-06-30 12:57       ` Ludovic Desroches
2017-06-30 13:01         ` m18063
2017-06-29 11:44 ` [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support Claudiu Beznea
2017-06-29 11:59   ` Baruch Siach
2017-06-29 12:16     ` Alexandre Belloni
2017-06-30 12:28       ` m18063 [this message]
2017-06-29 15:04   ` Ludovic Desroches
2017-06-30 12:32     ` m18063

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f204f169-1939-31cc-05af-8a715b86e082@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=baruch@tkos.co.il \
    --cc=cristian.birsan@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    --cc=sza@esh.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).