linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Chen Yu <yu.c.chen@intel.com>,
	Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: Re: [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable
Date: Sun, 03 Mar 2019 13:20:40 -0800	[thread overview]
Message-ID: <f214b0d82fce14c374aa6b548742c999513d9046.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0ik6oHCXD23tURsRXRj1-C-Z=S6y+KEiRxe0zJpGrKa+Q@mail.gmail.com>

On Sun, 2019-03-03 at 18:03 +0100, Rafael J. Wysocki wrote:
> On Fri, Mar 1, 2019 at 6:39 PM Srinivas Pandruvada
> <srinivas.pandruvada@linux.intel.com> wrote:
> > 
> > On Fri, 2019-03-01 at 13:43 +0100, Rafael J. Wysocki wrote:
> > > Hi All,
> > > 
> > > This is how I would fix the issue reported in BZ 200759 (see this
> > > patch series
> > > from Yu too: https://marc.info/?l=linux-pm&m=155137672924029&w=2)
> > > .
> > > 
> > > Patch [1/2] causes intel_pstate to update all policies if it gets
> > > a
> > > _PPC change
> > > notification and sees a global turbo disable/enable change.
> > > 
> > > Patch [2/2] makes it update cpuinfo.max_freq for all policies in
> > > those cases.
> > > 
> > > The patches here have not been tested yet, so testing would be
> > > much
> > > appreciated.
> > > 
> > > Of course, comments are welcome too!
> > 
> > This is the only platform, someone reported such issue.
> 
> I don't think this matters.
> 
> First, it doesn't mean that no other problems have this problem.
> 
> Second, the current handling of MSR_IA32_MISC_ENABLE_TURBO_DISABLE
> changes in intel_pstate is not sufficient if the changes is from set
> to unset anyway.
Any platform with HWP, you can't even notify of this change. So any
platform beyond SKL is not useful.
Fixing is always good :-) 



  reply	other threads:[~2019-03-03 21:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-01 12:43 [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable Rafael J. Wysocki
2019-03-01 12:45 ` [RFT][PATCH 1/2] cpufreq: intel_pstate: Driver-specific handling of _PPC updates Rafael J. Wysocki
2019-03-01 12:47 ` [RFT][PATCH 2/2] cpufreq: intel_pstate: Update max CPU frequency on global turbo changes Rafael J. Wysocki
2019-03-01 12:57   ` [RFT][Update][PATCH " Rafael J. Wysocki
2019-03-04 14:39     ` Yu Chen
2019-03-05 10:42     ` Quentin Perret
2019-03-05 10:50       ` Rafael J. Wysocki
2019-03-05 10:58         ` Rafael J. Wysocki
2019-03-05 11:44           ` Peter Zijlstra
2019-03-05 11:52             ` Rafael J. Wysocki
2019-03-05 12:00             ` Quentin Perret
2019-03-05 12:24               ` Peter Zijlstra
2019-03-05 17:02               ` Rafael J. Wysocki
2019-03-05 17:37                 ` Quentin Perret
2019-03-06 10:05                   ` Rafael J. Wysocki
2019-03-07 11:02                     ` Quentin Perret
2019-03-07 11:23                       ` Peter Zijlstra
2019-03-07 11:49                         ` Quentin Perret
2019-03-07 11:25                       ` Rafael J. Wysocki
2019-03-07 11:59                         ` Quentin Perret
2019-03-05 11:01         ` Quentin Perret
2019-03-01 17:39 ` [RFT][PATCH 0/2] cpufreq: intel_pstate: Handle _PPC updates on global turbo disable/enable Srinivas Pandruvada
2019-03-02 10:30   ` Yu Chen
2019-03-02 16:24     ` Srinivas Pandruvada
2019-03-03 17:03   ` Rafael J. Wysocki
2019-03-03 21:20     ` Srinivas Pandruvada [this message]
2019-03-03 21:51       ` Rafael J. Wysocki
2019-03-04  4:06         ` Srinivas Pandruvada
2019-03-04  9:41           ` Rafael J. Wysocki
2019-03-04 18:06             ` Srinivas Pandruvada
2019-03-04 21:57               ` Rafael J. Wysocki
2019-03-04 23:04                 ` Srinivas Pandruvada
2019-03-05  8:40                   ` Rafael J. Wysocki
2019-03-03 22:42 ` Gabriele Mazzotta
2019-03-04  9:58   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f214b0d82fce14c374aa6b548742c999513d9046.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=gabriele.mzt@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    --cc=yu.c.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).