* [PATCH v2] gpu: ipu-v3: use swap()
@ 2021-07-13 14:05 Salah Triki
2021-07-27 14:11 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2021-07-13 14:05 UTC (permalink / raw)
To: p.zabel, festevam, alexdeucher; +Cc: linux-kernel, dri-devel
Use swap() instead of implementing it since it makes code cleaner.
Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
Changes since v1:
- Remove the declaration of tmp
- Fix typo in the description
drivers/gpu/ipu-v3/ipu-image-convert.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/ipu-v3/ipu-image-convert.c b/drivers/gpu/ipu-v3/ipu-image-convert.c
index aa1d4b6d278f..af1612044eef 100644
--- a/drivers/gpu/ipu-v3/ipu-image-convert.c
+++ b/drivers/gpu/ipu-v3/ipu-image-convert.c
@@ -990,7 +990,7 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx,
const struct ipu_image_pixfmt *fmt = image->fmt;
unsigned int row, col, tile = 0;
u32 H, top, y_stride, uv_stride;
- u32 uv_row_off, uv_col_off, uv_off, u_off, v_off, tmp;
+ u32 uv_row_off, uv_col_off, uv_off, u_off, v_off;
u32 y_row_off, y_col_off, y_off;
u32 y_size, uv_size;
@@ -1021,11 +1021,8 @@ static int calc_tile_offsets_planar(struct ipu_image_convert_ctx *ctx,
u_off = y_size - y_off + uv_off;
v_off = (fmt->uv_packed) ? 0 : u_off + uv_size;
- if (fmt->uv_swapped) {
- tmp = u_off;
- u_off = v_off;
- v_off = tmp;
- }
+ if (fmt->uv_swapped)
+ swap(u_off, v_off);
image->tile[tile].offset = y_off;
image->tile[tile].u_off = u_off;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] gpu: ipu-v3: use swap()
2021-07-13 14:05 [PATCH v2] gpu: ipu-v3: use swap() Salah Triki
@ 2021-07-27 14:11 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2021-07-27 14:11 UTC (permalink / raw)
To: Salah Triki, festevam, alexdeucher; +Cc: linux-kernel, dri-devel
On Tue, 2021-07-13 at 15:05 +0100, Salah Triki wrote:
> Use swap() instead of implementing it since it makes code cleaner.
>
> Signed-off-by: Salah Triki <salah.triki@gmail.com>
> ---
>
> Changes since v1:
> - Remove the declaration of tmp
> - Fix typo in the description
Thank you, I've changed the subject to "gpu: ipu-v3: image-convert: use
swap()" and applied to imx-drm/next.
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-27 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 14:05 [PATCH v2] gpu: ipu-v3: use swap() Salah Triki
2021-07-27 14:11 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).