From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE500C433DF for ; Tue, 19 May 2020 00:59:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD5B120674 for ; Tue, 19 May 2020 00:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ozlabs.org header.i=@ozlabs.org header.b="iIVVHUQA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgESA7a (ORCPT ); Mon, 18 May 2020 20:59:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726696AbgESA73 (ORCPT ); Mon, 18 May 2020 20:59:29 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79387C061A0C; Mon, 18 May 2020 17:59:29 -0700 (PDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49QyFn2C35z9sT3; Tue, 19 May 2020 10:59:25 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1589849966; bh=8/+JurzWor9GOkMEO6UBnJlAsXzwZLYg4x/TZn37qos=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=iIVVHUQASagv59C+VIQOnQtpogsxpFdYvze4yvfpBcmwuNCyaevLKzU9l2sIp0ilw +DYckKCW1ryryi5bRywI8FSOStoP5rWY1J9s9Ts4y7BqkJlZoDorFB3x2KPXE9Es3b 0JxJQXpDh8S/Ce+oL/DjZ2jkta34Dv6kCHqqix+yWfD8flS0vD8QQDt0ikHXmU6NNj gzOyPPDAvx0aRDJZpE5PwnF3W5N1fpOW1oOpAuzeKOBJbh3muK4kjcFquhKXzsmGuK Xfs/D5kHCefQ26xWcxTgb0a+WrZzXmdb5tssO2YA/U15uSeIf2Q222xIsAAGrZrDY8 0uT1DOQn/49bg== Message-ID: Subject: Re: [PATCH] net: bmac: Fix stack corruption panic in bmac_probe() From: Jeremy Kerr To: userm57@yahoo.com, Finn Thain , "David S. Miller" Cc: Paul Mackerras , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Herrenschmidt Date: Tue, 19 May 2020 08:59:24 +0800 In-Reply-To: <05aa357d-4b9c-4038-c0f4-1bfea613c6e4@yahoo.com> References: <769e9041942802d0e9ff272c12ee359a04b84a90.1589761211.git.fthain@telegraphics.com.au> <43d5717e7157fd300fd5bf893e517bbdf65c36f4.camel@ozlabs.org> <05aa357d-4b9c-4038-c0f4-1bfea613c6e4@yahoo.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stan, > The new kernel compiled and booted with no errors, with these > STACKPROTECTOR options in .config (the last two revealed the bug): > > CONFIG_HAVE_STACKPROTECTOR=y > CONFIG_CC_HAS_STACKPROTECTOR_NONE=y > CONFIG_STACKPROTECTOR=y > CONFIG_STACKPROTECTOR_STRONG=y Brilliant, thanks for testing. I'll send a standalone patch to netdev. Cheers, Jeremy