* [PATCH] igc: Fix an error handling path in 'igc_probe()'
@ 2021-06-12 20:00 Christophe JAILLET
2021-06-21 12:20 ` [Intel-wired-lan] " Fuxbrumer, Dvora
2021-06-22 6:50 ` Neftin, Sasha
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-06-12 20:00 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, kuba,
jeffrey.t.kirsher, sasha.neftin
Cc: intel-wired-lan, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
call, as already done in the remove function.
Fixes: c9a11c23ceb6 ("igc: Add netdev")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 3f6b6d4543a8..6389a41cacc1 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -6057,6 +6057,7 @@ static int igc_probe(struct pci_dev *pdev,
err_ioremap:
free_netdev(netdev);
err_alloc_etherdev:
+ pci_disable_pcie_error_reporting(pdev);
pci_release_mem_regions(pdev);
err_pci_reg:
err_dma:
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-wired-lan] [PATCH] igc: Fix an error handling path in 'igc_probe()'
2021-06-12 20:00 [PATCH] igc: Fix an error handling path in 'igc_probe()' Christophe JAILLET
@ 2021-06-21 12:20 ` Fuxbrumer, Dvora
2021-06-22 6:50 ` Neftin, Sasha
1 sibling, 0 replies; 3+ messages in thread
From: Fuxbrumer, Dvora @ 2021-06-21 12:20 UTC (permalink / raw)
To: Christophe JAILLET, jesse.brandeburg, anthony.l.nguyen, davem,
kuba, jeffrey.t.kirsher, sasha.neftin
Cc: netdev, kernel-janitors, intel-wired-lan, linux-kernel
On 6/12/2021 23:00, Christophe JAILLET wrote:
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: c9a11c23ceb6 ("igc: Add netdev")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] igc: Fix an error handling path in 'igc_probe()'
2021-06-12 20:00 [PATCH] igc: Fix an error handling path in 'igc_probe()' Christophe JAILLET
2021-06-21 12:20 ` [Intel-wired-lan] " Fuxbrumer, Dvora
@ 2021-06-22 6:50 ` Neftin, Sasha
1 sibling, 0 replies; 3+ messages in thread
From: Neftin, Sasha @ 2021-06-22 6:50 UTC (permalink / raw)
To: Christophe JAILLET, jesse.brandeburg, anthony.l.nguyen, davem, kuba
Cc: intel-wired-lan, netdev, linux-kernel, kernel-janitors, Neftin,
Sasha, Edri, Michael
On 6/12/2021 23:00, Christophe JAILLET wrote:
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: c9a11c23ceb6 ("igc: Add netdev")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 3f6b6d4543a8..6389a41cacc1 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -6057,6 +6057,7 @@ static int igc_probe(struct pci_dev *pdev,
> err_ioremap:
> free_netdev(netdev);
> err_alloc_etherdev:
> + pci_disable_pcie_error_reporting(pdev);
> pci_release_mem_regions(pdev);
> err_pci_reg:
> err_dma:
>
Thanks for this patch.
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-22 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 20:00 [PATCH] igc: Fix an error handling path in 'igc_probe()' Christophe JAILLET
2021-06-21 12:20 ` [Intel-wired-lan] " Fuxbrumer, Dvora
2021-06-22 6:50 ` Neftin, Sasha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).