From: Scott Branden <scott.branden@broadcom.com>
To: Jon Mason <jon.mason@broadcom.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] thermal: broadcom: ns-thermal: default on iProc SoCs
Date: Mon, 29 May 2017 09:21:51 -0700 [thread overview]
Message-ID: <f2544b8e-59fe-8cbc-5598-bd2a2b325a39@broadcom.com> (raw)
In-Reply-To: <CAC3K-4oDnL2oiUDo29dLofHX3hQe2-d1xs=Cduwm==BjLH1djQ@mail.gmail.com>
Hi Jon,
On 17-04-28 01:50 PM, Jon Mason wrote:
> On Fri, Apr 28, 2017 at 4:36 PM, Scott Branden
> <scott.branden@broadcom.com> wrote:
>>
>> On 17-04-28 01:11 PM, Jon Mason wrote:
>>> Tweak the Kconfig description to mention support for NSP and make the
>>> default on for iProc based platforms.
>>>
>>> Signed-off-by: Jon Mason <jon.mason@broadcom.com>
>>> ---
>>> drivers/thermal/broadcom/Kconfig | 9 +++++----
>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/thermal/broadcom/Kconfig
>>> b/drivers/thermal/broadcom/Kconfig
>>> index f0dea8a..b6f4b85 100644
>>> --- a/drivers/thermal/broadcom/Kconfig
>>> +++ b/drivers/thermal/broadcom/Kconfig
>>> @@ -1,8 +1,9 @@
>>> config BCM_NS_THERMAL
>>> tristate "Northstar thermal driver"
>>> depends on ARCH_BCM_IPROC || COMPILE_TEST
>> If this driver is used on these SoCs then it:
>> depends on ARCH_BCM_NSP || ARCH_BCM_5301X || COMPILE_TEST
>> ?
> The code referenced is outside of this patch, as that code was already
> existing from when the driver was submitted.
>
> I did some checking and NS2 and Cygnus do not have the registers in
> use by this driver. So, you are correct in that this driver will
> never be used for them. So, this is slightly over-permissive in
> allowing a driver to be selected that could not ever be used on
> non-NS/NSP hardware. But barring an incorrect DT string, it would
> only result in an slightly larger kernel than necessary.
>
> I'll do a follow-on patch to correct this with your suggestion above,
> and push it separately (unless a v4 is needed on this series).
Please submit the follow on patch.
>
> Thanks,
> Jon
Thanks,
Scott
next prev parent reply other threads:[~2017-05-29 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 20:11 [PATCH v3 0/3] thermal: broadcom: Add NSP Thermal Support Jon Mason
2017-04-28 20:11 ` [PATCH v3 1/3] ARM: BCM: Enable thermal support for NSP SoCs Jon Mason
2017-05-19 18:29 ` Florian Fainelli
2017-04-28 20:11 ` [PATCH v3 2/3] thermal: broadcom: ns-thermal: default on iProc SoCs Jon Mason
2017-04-28 20:36 ` Scott Branden
2017-04-28 20:50 ` Jon Mason
2017-05-29 16:21 ` Scott Branden [this message]
2017-05-19 18:33 ` Florian Fainelli
2017-04-28 20:11 ` [PATCH v3 3/3] ARM: dts: NSP: Add Thermal Support Jon Mason
2017-05-19 18:31 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2544b8e-59fe-8cbc-5598-bd2a2b325a39@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=jon.mason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).