From: Randy Dunlap <rdunlap@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
David Howells <dhowells@redhat.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Zheng Zengkai <zhengzengkai@huawei.com>,
Tom Rix <trix@redhat.com>,
linux-afs@lists.infradead.org,
Marc Dionne <marc.dionne@auristor.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] afs: fix no return statement in function returning non-void
Date: Tue, 15 Jun 2021 16:58:01 -0700 [thread overview]
Message-ID: <f2764b10-dd0d-cabf-0264-131ea5829fed@infradead.org> (raw)
In-Reply-To: <CAHk-=whARK9gtk0BPo8Y0EQqASNG9SfpF1MRqjxf43OO9F0vag@mail.gmail.com>
On 6/15/21 7:49 AM, Linus Torvalds wrote:
> On Tue, Jun 15, 2021 at 4:55 AM David Howells <dhowells@redhat.com> wrote:
>>
>> From: Zheng Zengkai <zhengzengkai@huawei.com>
>>
>> Add missing return to fix following compilation issue:
>>
>> fs/afs/dir.c: In function ‘afs_dir_set_page_dirty’:
>> fs/afs/dir.c:51:1: error: no return statement in function
>> returning non-void [-Werror=return-type]
>
> This warning is actively wrong, and the patch is the wrong thing to do.
>
> What compiler / architecture / config?
>
> Because BUG() should have an "unreachable()", and the compiler should
> know that a return statement isn't needed (and adding it shouldn't
> make any difference).
>
> And it's not warning for me when I build that code. So I really think
> the real bug is entirely somewhere else, and this patch is papering
> over the real problem.
Hi,
Some implementations of BUG() are macros, not functions, so "unreachable"
is not applicable AFAIK.
--
~Randy
next prev parent reply other threads:[~2021-06-15 23:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 11:55 [PATCH] afs: fix no return statement in function returning non-void David Howells
2021-06-15 12:03 ` David Howells
2021-06-15 14:49 ` Linus Torvalds
2021-06-15 23:58 ` Randy Dunlap [this message]
2021-06-16 0:32 ` Linus Torvalds
2021-06-16 1:38 ` Randy Dunlap
2021-06-16 2:19 ` Randy Dunlap
2021-06-16 3:15 ` Zheng Zengkai
2021-06-16 12:56 ` Tom Rix
2021-06-16 14:34 ` Linus Torvalds
2021-06-16 16:22 ` Tom Rix
2021-06-16 16:29 ` Linus Torvalds
2021-06-18 15:23 ` Arnd Bergmann
2021-06-16 13:41 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2021-03-27 12:16 Zheng Zengkai
2021-03-31 2:32 ` Zheng Zengkai
2021-04-08 14:06 ` David Howells
2021-04-19 22:31 ` Randy Dunlap
2021-05-27 19:48 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2764b10-dd0d-cabf-0264-131ea5829fed@infradead.org \
--to=rdunlap@infradead.org \
--cc=dhowells@redhat.com \
--cc=hulkci@huawei.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=torvalds@linux-foundation.org \
--cc=trix@redhat.com \
--cc=zhengzengkai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).