From: Rodolfo Giometti <giometti@enneenne.com>
To: "N, Pandith" <pandith.n@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>,
"D, Lakshmi Sowjanya" <lakshmi.sowjanya.d@intel.com>,
"T R, Thejesh Reddy" <thejesh.reddy.t.r@intel.com>,
"Hall, Christopher S" <christopher.s.hall@intel.com>
Subject: Re: PPS functionality for Intel Timed I/O
Date: Mon, 6 Feb 2023 11:46:35 +0100 [thread overview]
Message-ID: <f2788a74-19f8-8992-5b92-427c7b2a27ab@enneenne.com> (raw)
In-Reply-To: <BYAPR11MB32408E2D9758BD01EC65FB49E1DA9@BYAPR11MB3240.namprd11.prod.outlook.com>
On 06/02/23 11:16, N, Pandith wrote:
> Hi Rodolfo,
Hi
>> -----Original Message-----
>> From: Rodolfo Giometti <giometti@enneenne.com>
>> Sent: Monday, January 30, 2023 7:57 PM
>> To: N, Pandith <pandith.n@intel.com>
>> Cc: linux-kernel@vger.kernel.org; Sangannavar, Mallikarjunappa
>> <mallikarjunappa.sangannavar@intel.com>; D, Lakshmi Sowjanya
>> <lakshmi.sowjanya.d@intel.com>; T R, Thejesh Reddy
>> <thejesh.reddy.t.r@intel.com>; Hall, Christopher S
>> <christopher.s.hall@intel.com>
>> Subject: Re: PPS functionality for Intel Timed I/O
>> Within kernel sources PPS clients and PPS generators are placed into different
>> directories, so I suppose is better to deploy two different pieces of code.
>>
> We are planning to add a new PPS generator driver in drivers/pps/generators
> i) Can this driver use pps_register_source to register Intel Timed I/O device for pulse generation ?
Nope. This function is for pps clients only. PPS generators should generate
their pulses according to system clock so they don't needed any registrations at
all under PPS layer.
> ii) To start/stop pulse, we are planning to add additional sysfs attribute from our main driver.
> Something like : /sys/class/ppsX/enable_pin
> This is needed for users to start/stop pulse generation.
If you are still talking about PPS generators they have no entries under
/sys/class/ppsX/ (just clients have). So you can add an entry under your driver
to do so.
>> However pay attention to the fact that a PPS generator should be referred to
>> system's main clock and not to peripherals' clock.
>>
> We can sync with the system time for pulse generation.
Mmm... I'm not sure this is correct since PPS generators should generate their
pulses according to system clock and not according to their internal clocks even
if they are synced with the system clock.
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
next prev parent reply other threads:[~2023-02-06 10:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 12:55 PPS functionality for Intel Timed I/O N, Pandith
2023-01-30 13:45 ` Rodolfo Giometti
2023-01-30 14:11 ` N, Pandith
2023-01-30 14:26 ` Rodolfo Giometti
2023-02-06 10:16 ` N, Pandith
2023-02-06 10:46 ` Rodolfo Giometti [this message]
2023-02-15 7:09 ` N, Pandith
2023-02-15 7:46 ` Rodolfo Giometti
2023-10-06 5:31 ` N, Pandith
2023-10-06 6:23 ` Rodolfo Giometti
2023-10-06 8:34 ` andriy.shevchenko
2023-10-06 8:34 ` andriy.shevchenko
2023-10-06 8:57 ` Rodolfo Giometti
2023-10-06 9:06 ` andriy.shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2788a74-19f8-8992-5b92-427c7b2a27ab@enneenne.com \
--to=giometti@enneenne.com \
--cc=christopher.s.hall@intel.com \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=pandith.n@intel.com \
--cc=thejesh.reddy.t.r@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).