From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757238AbcJYOiO (ORCPT ); Tue, 25 Oct 2016 10:38:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55652 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcJYOiN (ORCPT ); Tue, 25 Oct 2016 10:38:13 -0400 Subject: Re: [PATCH 02/10] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first. To: Suganath Prabu S , JBottomley@Parallels.com, jejb@kernel.org, hch@infradead.org References: <1476966018-10457-1-git-send-email-suganath-prabu.subramani@broadcom.com> <1476966018-10457-3-git-send-email-suganath-prabu.subramani@broadcom.com> Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Sathya.Prakash@broadcom.com, kashyap.desai@broadcom.com, krishnaraddi.mankani@broadcom.com, linux-kernel@vger.kernel.org, chaitra.basappa@broadcom.com, sreekanth.reddy@broadcom.com From: Tomas Henzl Message-ID: Date: Tue, 25 Oct 2016 16:38:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1476966018-10457-3-git-send-email-suganath-prabu.subramani@broadcom.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 25 Oct 2016 14:38:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.10.2016 14:20, Suganath Prabu S wrote: > No. of MSIX vectors supported = min (Total no. of CPU cores, > MSIX vectors supported by card) > > when RDPQ is disabled "max_msix_vectors" module parameter which was > declared as global was set to '8' and hence if there are more than one card > in system among which if RDPQ disabled card is enumerated first then only 8 > MSIX vectors was getting enabled for all the cards(including RDPQ enabled > card,which can support more than 8 MSIX vectors). > > Used local variable instead of global variable ,if RDPQ is disabled this > local variable is set to '8' else it is set to "max_msix_vectors" (by > default this is set to -1, whose value can be set by user during driver > load time).So now regardless of whether RDPQ disabled card is enumerated > first or RDPQ enabled card is enumerated first , MSIX vectors enabled > depends on the cards capability. > > Signed-off-by: Chaitra P B > Signed-off-by: Sathya Prakash > Signed-off-by: Suganath Prabu S Reviewed-by: Tomas Henzl Tomas