From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752402AbXCMXks (ORCPT ); Tue, 13 Mar 2007 19:40:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752135AbXCMXks (ORCPT ); Tue, 13 Mar 2007 19:40:48 -0400 Received: from wr-out-0506.google.com ([64.233.184.239]:21572 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752402AbXCMXkr (ORCPT ); Tue, 13 Mar 2007 19:40:47 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Irs2yS3pK+V2SrzALKRSAERy5/74qk0qjhCv+xi9E74b6wl+vfc6Q9aNe5Iv9CQzW1gowrdYCYOAQzXvnIguk/Mb2u8SweWlSkMcV987ApxdZBA3eQLaNUtQ3OLNMv3M85eATBDZsfH0MNzPhSHzqYuJpnxkwI6JqdeW0jpE/68= Message-ID: Date: Tue, 13 Mar 2007 16:40:41 -0700 From: "Michael K. Edwards" To: "Christoph Hellwig" , "Michael K. Edwards" , "David Miller" , alan@lxorguk.ukuu.org.uk, 7eggert@gmx.de, dada1@cosmosbay.com, linux-kernel@vger.kernel.org Subject: Re: sys_write() racy for multi-threaded append? In-Reply-To: <20070313190949.GA3417@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070313022430.57503b08@lxorguk.ukuu.org.uk> <20070313.004224.41634994.davem@davemloft.net> <20070313190949.GA3417@infradead.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 3/13/07, Christoph Hellwig wrote: > Michael, please stop spreading this utter bullshit _now_. You're so > full of half-knowledge that it's not funny anymore, and you try > to insult people knowing a few magniutes more than you left and right. Thank you Christoph for that informative response to my comments. I take it that you consider read_write.c to be code of the highest quality and maintainability. If you have something specific in mind when you write "utter bullshit" and "half-knowledge", I'd love to hear it. Now, for those who still care to respond as if improving the kernel were a goal that you and I can share, a question: When generic_file_llseek needs the inode in order to retrieve the current file size, it goes through f_mapping (the pagecache entry?) rather than through f_path.dentry (the dentry cache?). All other inode retrievals in read_write.c go through f_path.dentry. Why? Or is this a question that can only be asked on linux-fsdevel? Cheers, - Michael