linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
@ 2018-10-16  9:53 ` Enric Balletbo i Serra
  2018-10-29 13:52   ` Andrzej Hajda
  0 siblings, 1 reply; 2+ messages in thread
From: Enric Balletbo i Serra @ 2018-10-16  9:53 UTC (permalink / raw)
  To: linux-kernel
  Cc: kernel, Andrzej Hajda, Daniel Vetter, Marek Szyprowski,
	Archit Taneja, zain wang, dri-devel, Lin Huang, David Airlie,
	Laurent Pinchart, Sean Paul, Jeffy Chen

This patch avoids that building the bridge/analogix source code with
smatch triggers complaints about inconsistent indenting. It also fixes
a typo in DRM_ERROR message, attch is replaced for attach.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---

Changes in v2:
- Fix typo s/attch/attach/
- Add Reviewed-by Laurent Pinchart

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index d68986cea132..3987d5fc9c0d 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge)
 	 * plat_data->attch return, that's why we record the connector
 	 * point after plat attached.
 	 */
-	 if (dp->plat_data->attach) {
-		 ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
-		 if (ret) {
-			 DRM_ERROR("Failed at platform attch func\n");
-			 return ret;
-		 }
+	if (dp->plat_data->attach) {
+		ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
+		if (ret) {
+			DRM_ERROR("Failed at platform attach func\n");
+			return ret;
+		}
 	}
 
 	if (dp->plat_data->panel) {
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch
  2018-10-16  9:53 ` [PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch Enric Balletbo i Serra
@ 2018-10-29 13:52   ` Andrzej Hajda
  0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2018-10-29 13:52 UTC (permalink / raw)
  To: Enric Balletbo i Serra, linux-kernel
  Cc: kernel, Daniel Vetter, Marek Szyprowski, Archit Taneja,
	zain wang, dri-devel, Lin Huang, David Airlie, Laurent Pinchart,
	Sean Paul, Jeffy Chen

On 16.10.2018 11:53, Enric Balletbo i Serra wrote:
> This patch avoids that building the bridge/analogix source code with
> smatch triggers complaints about inconsistent indenting. It also fixes
> a typo in DRM_ERROR message, attch is replaced for attach.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Queued to drm-misc-next.

Regards
Andrzej


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-29 13:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20181016095350epcas4p3a71b29adb3fbeb8075568de20d43e3a0@epcas4p3.samsung.com>
2018-10-16  9:53 ` [PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch Enric Balletbo i Serra
2018-10-29 13:52   ` Andrzej Hajda

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).