From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754045AbcHXMKd (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Aug 2016 08:10:33 -0400
Received: from mout.web.de ([217.72.192.78]:53970 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750954AbcHXMKb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Aug 2016 08:10:31 -0400
Subject: Re: Replacing specific kmalloc() calls by kmalloc_array()?
To: Paolo Bonzini <pbonzini@redhat.com>
References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net>
 <033d8595-d051-1fa8-95b1-5d2056eb5667@users.sourceforge.net>
 <57B562F3.1080004@bfs.de> <alpine.DEB.2.10.1608180502080.3107@hadrien>
 <9db1986a-9b93-72ca-f35e-85b5b5e9f351@redhat.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>, walter harms <wharms@bfs.de>,
        kvm@vger.kernel.org, linux-s390@vger.kernel.org,
        =?UTF-8?Q?Christian_Borntr=c3=a4ger?= <borntraeger@de.ibm.com>,
        Cornelia Huck <cornelia.huck@de.ibm.com>,
        David Hildenbrand <dahi@linux.vnet.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f2c99dcc-8dea-b8a4-5244-08bb7c0ee1e8@users.sourceforge.net>
Date: Wed, 24 Aug 2016 14:10:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <9db1986a-9b93-72ca-f35e-85b5b5e9f351@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:PslBMcJjDQAuBL5y3bmeLNlklfmQLIN4nwuDZLzFTQ5Ft8+TG5M
 E399chG4Xid2yCNkvVXmpIgo1jY0WV19oEhf28qi5W5QEUwgMsgRzgp3sSOJfL5OFbWt1fY
 br4yUj2ZOSgUzg8jWvH+WekKrrmrzE8Z+MX46ZS+PTpPqgStIUgYOKUbd2dN8bt1fIsEMo3
 1Vq0cv/CXKOp0KdgkFTPA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Ptx6t1gtTZI=:8QIDC+SHHZDmv7q5GQTzeZ
 Zwm+hVwZZVS0SrJqtWdHQBAN9+IBmMa8oVHq/m6OjYvzBTf0sng8QlLwy9DANNozYFGPVIkrA
 CVZFgtP+6PqRcpbsOncXHi5TGaqO7K8t4627s3OirFR5HqQw87vXsVuLILbo6uIXbBzRFr/AH
 66pl+MfxCLPTGbnKOGRq8SlINGtjFNuD6LSSgZT95lV+Bmf37Mo0HikYDIYP0s/krF6+NIewK
 F6mWvCL7id+y0m//8J8ygNhxAdeR1acPJtOxx9kZgAkAJpjNYPmwbK+/hO71ySngQ8RjkFqNd
 z/Qcomus8Vr371TCeH9BCUiiqw7XBiZM07EzhcJw8WC+WvKwk/Y4ulwI5RySIs4bQKRIkbvfc
 sKAi71iILk60jgui7Xo081iKgQON7amQK93UzrU8I7RieR+fj34YXK8PKpseUipuLZTo763d6
 oyokTW8SdR2TidAUY242knBLiw8zbettBVD3f7gWZYH7nfJU0yyQM58y1qCegSG0cRR3bwxxP
 pwakJ+DnCXQLDORabpviqhRqqJDL8eAikV1MHUQIWt7zHgUwUUq2vJJv9QVICvxZsnI7SITaR
 uW4cViAXL/op6P77MSZEY5nfVZ+/0QdIhgckWh9cWexGquX0C8Ga9guCpnEHTr2UR3iJ8iUmw
 xw/fE5XCx580255XJsUKlxgZA0ArUC1+ZDQOalm14qoMf+laczQYjlKCYU1WhJFQgQKV8p4FJ
 Ud5+KsCobT2C9GkobFmUPx66DP4EdSNoWdfwLmndpQUrf4coTgkPcrE3CyAbu9uGh8ewy49pn
 es3pTCK
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Or kmalloc_array, since zeroing is not necessary.  Might be an idea for
> a new Coccinelle script, like
> 
> - kmalloc (N * sizeof T, GFP)
> + kmalloc_array(N, sizeof T, GFP)

I have picked your idea up. The corresponding script for the semantic
patch language became longer than your general suggestion
(if additional source code control flow aspects are integrated).

Would it make sense to check any more function combinations
in a similar way?

Regards,
Markus