Re: [PATCH v4 0/2] x86/mce: Handle error injection failure in mce-inject module

From: "Koralahalli Channabasappa, Smita" <skoralah@amd.com>
To: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
	x86@kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>,
	"H . Peter Anvin" <hpa@zytor.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v4 0/2] x86/mce: Handle error injection failure in mce-inject module
Date: Fri, 11 Mar 2022 14:55:39 -0600	[thread overview]
Message-ID: <f2d7c8fd-5178-a40b-7f15-5e0736388aa4@amd.com> (raw)
In-Reply-To: <20220214233640.70510-1-Smita.KoralahalliChannabasappa@amd.com>

Hi all,

Do you have any comments that needs to be addressed on these set of patches?

Thanks,
Smita.

On 2/14/22 5:36 PM, Smita Koralahalli wrote:

> This set of patches handles a scenario where error injection fails silently
> on mce-inject module and returns appropriate error code to userspace.
>
> Error injection fails if the platform enforces write ignored behavior on
> status registers and the first patch checks for writes ignored from
> MCA_STATUS register and returns appropriate error code to user.
>
> The second patch assigns and returns the error code to userspace when none
> of the CPUs are online.
>
> Smita Koralahalli (2):
>    x86/mce: Check for writes ignored in MCA_STATUS register
>    x86/mce/mce-inject: Return appropriate error code if CPUs are offline
>
>   arch/x86/kernel/cpu/mce/core.c   |  1 +
>   arch/x86/kernel/cpu/mce/inject.c | 42 +++++++++++++++++++++++++++++---
>   2 files changed, 39 insertions(+), 4 deletions(-)
>