From: David Hildenbrand <david@redhat.com>
To: Liu Song <fishland@aliyun.com>,
akpm@linux-foundation.org, mhocko@suse.com, hannes@cmpxchg.org,
daniel.m.jordan@oracle.com, laoar.shao@gmail.com,
yang.shi@linux.alibaba.com, aryabinin@virtuozzo.com,
mgorman@techsingularity.net
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, liu.song11@zte.com.cn
Subject: Re: [PATCH] mm/vmscan.c: remove unused return value of shrink_node
Date: Thu, 28 Nov 2019 16:10:25 +0100 [thread overview]
Message-ID: <f2e7b906-99b8-8b85-2be9-ee6f9d0e11ea@redhat.com> (raw)
In-Reply-To: <20191128143524.3223-1-fishland@aliyun.com>
On 28.11.19 15:35, Liu Song wrote:
> From: Liu Song <liu.song11@zte.com.cn>
>
> The return value of shrink_node is not used, so remove
> unnecessary operations.
>
> Signed-off-by: Liu Song <liu.song11@zte.com.cn>
> ---
> mm/vmscan.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 44df66a98f2a..fd282d86f4ad 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2652,7 +2652,7 @@ static bool pgdat_memcg_congested(pg_data_t *pgdat, struct mem_cgroup *memcg)
> (memcg && memcg_congested(pgdat, memcg));
> }
>
> -static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> +static void shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> {
> struct reclaim_state *reclaim_state = current->reclaim_state;
> unsigned long nr_reclaimed, nr_scanned;
> @@ -2818,8 +2818,6 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
> */
> if (reclaimable)
> pgdat->kswapd_failures = 0;
> -
> - return reclaimable;
> }
>
> /*
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
parent reply other threads:[~2019-11-28 15:10 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20191128143524.3223-1-fishland@aliyun.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2e7b906-99b8-8b85-2be9-ee6f9d0e11ea@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=daniel.m.jordan@oracle.com \
--cc=fishland@aliyun.com \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liu.song11@zte.com.cn \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).