From: shuah <shuah@kernel.org>
To: "Dmitry V. Levin" <ldv@altlinux.org>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Elvira Khabirova <lineprinter@altlinux.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v9 7/7] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO
Date: Mon, 8 Apr 2019 11:51:45 -0600 [thread overview]
Message-ID: <f2f015da-35d4-7207-cd57-e6589cd9d2c4@kernel.org> (raw)
In-Reply-To: <20190408174236.GH11889@altlinux.org>
On 4/8/19 11:42 AM, Dmitry V. Levin wrote:
> Check whether PTRACE_GET_SYSCALL_INFO semantics implemented in the kernel
> matches userspace expectations.
>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Elvira Khabirova <lineprinter@altlinux.org>
> Cc: Eugene Syromyatnikov <esyr@redhat.com>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
>
> Notes:
> v9: unchanged
> v8: unchanged
> v7: unchanged
> v6: made PTRACE_GET_SYSCALL_INFO return value checks strict
> v5: initial revision
>
> tools/testing/selftests/ptrace/.gitignore | 1 +
> tools/testing/selftests/ptrace/Makefile | 2 +-
> .../selftests/ptrace/get_syscall_info.c | 271 ++++++++++++++++++
> 3 files changed, 273 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/ptrace/get_syscall_info.c
>
> diff --git a/tools/testing/selftests/ptrace/.gitignore b/tools/testing/selftests/ptrace/.gitignore
> index b3e59d41fd82..cfcc49a7def7 100644
> --- a/tools/testing/selftests/ptrace/.gitignore
> +++ b/tools/testing/selftests/ptrace/.gitignore
> @@ -1 +1,2 @@
> +get_syscall_info
> peeksiginfo
> diff --git a/tools/testing/selftests/ptrace/Makefile b/tools/testing/selftests/ptrace/Makefile
> index 8a2bc5562179..4bc550b6b845 100644
> --- a/tools/testing/selftests/ptrace/Makefile
> +++ b/tools/testing/selftests/ptrace/Makefile
> @@ -1,5 +1,5 @@
> CFLAGS += -iquote../../../../include/uapi -Wall
>
> -TEST_GEN_PROGS := peeksiginfo
> +TEST_GEN_PROGS := get_syscall_info peeksiginfo
>
> include ../lib.mk
> diff --git a/tools/testing/selftests/ptrace/get_syscall_info.c b/tools/testing/selftests/ptrace/get_syscall_info.c
> new file mode 100644
> index 000000000000..28e972825b74
> --- /dev/null
> +++ b/tools/testing/selftests/ptrace/get_syscall_info.c
> @@ -0,0 +1,271 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later
> + *
This should be just GPL-2.0+
The rest looks good to me. Assuming this patch has dependency on the
rest of the patches in this series and once the above change is made:
Acked-by: Shuah Khan <shuah@kernel.org>
thnaks,
-- Shuah
next prev parent reply other threads:[~2019-04-08 17:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:40 [PATCH linux-next v9 0/7] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2019-04-08 17:41 ` [PATCH linux-next v9 1/7] nds32: fix asm/syscall.h Dmitry V. Levin
2019-04-09 7:57 ` Greentime Hu
2019-04-08 17:41 ` [PATCH linux-next v9 2/7] hexagon: define syscall_get_error() and syscall_get_return_value() Dmitry V. Levin
2019-04-08 17:41 ` [PATCH linux-next v9 3/7] mips: define syscall_get_error() Dmitry V. Levin
2019-04-08 17:42 ` [PATCH linux-next v9 4/7] parisc: " Dmitry V. Levin
2019-04-08 17:42 ` [PATCH linux-next v9 5/7] powerpc: " Dmitry V. Levin
2019-04-08 17:42 ` [PATCH linux-next v9 6/7] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2019-04-08 17:42 ` [PATCH linux-next v9 7/7] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO Dmitry V. Levin
2019-04-08 17:51 ` shuah [this message]
2019-04-08 18:04 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2f015da-35d4-7207-cd57-e6589cd9d2c4@kernel.org \
--to=shuah@kernel.org \
--cc=esyr@redhat.com \
--cc=ldv@altlinux.org \
--cc=lineprinter@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).