From: Shuah Khan <shuah@kernel.org>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
valentina.manea.m@gmail.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
peter.senna@gmail.com, Shuah Khan <shuahkh@osg.samsung.com>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] drivers: usb: usbip: Add missing break statement to switch
Date: Thu, 9 Feb 2017 12:44:32 -0700 [thread overview]
Message-ID: <f318f774-0afb-098f-b91d-f387ebd3cd33@kernel.org> (raw)
In-Reply-To: <20170209074956.GA3840@embeddedgus>
On 02/09/2017 12:49 AM, Gustavo A. R. Silva wrote:
> Add missing break statement to prevent the code for case
> USB_PORT_FEAT_C_RESET falling through to the default case.
>
> Addresses-Coverity-ID: 143155
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/usb/usbip/vhci_hcd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index c4724fb..e4cb9f0 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -313,6 +313,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
> default:
> break;
> }
> + break;
> default:
> usbip_dbg_vhci_rh(" ClearPortFeature: default %x\n",
> wValue);
>
Looks good to me.
Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
thanks,
-- Shuah
prev parent reply other threads:[~2017-02-09 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 7:49 [PATCH] drivers: usb: usbip: Add missing break statement to switch Gustavo A. R. Silva
2017-02-09 19:44 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f318f774-0afb-098f-b91d-f387ebd3cd33@kernel.org \
--to=shuah@kernel.org \
--cc=garsilva@embeddedor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.senna@gmail.com \
--cc=shuahkh@osg.samsung.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).