From: John Kacur <jkacur@redhat.com>
To: Daniel Wagner <wagi@monom.org>
Cc: Mike Galbraith <efault@gmx.de>,
RT <linux-rt-users@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Clark Williams <williams@redhat.com>,
Daniel Wagner <dwagner@suse.de>,
Johnathan Schwender <schwenderjonathan@gmail.com>,
Peter Xu <peterx@redhat.com>
Subject: Re: [ANNOUNCE] rt-tests-2.0
Date: Mon, 28 Jun 2021 09:50:25 -0400 (EDT) [thread overview]
Message-ID: <f31d9d37-df6d-90b0-8bf9-95156c27e8d@redhat.com> (raw)
In-Reply-To: <20210628081135.l7yvya7iaygb23ye@beryllium.lan>
On Mon, 28 Jun 2021, Daniel Wagner wrote:
> Hi Mike,
>
> On Sat, Jun 26, 2021 at 02:45:27PM +0200, Mike Galbraith wrote:
> > On Sat, 2021-06-26 at 13:47 +0200, Mike Galbraith wrote:
> > > On Sat, 2021-06-26 at 08:55 +0200, Mike Galbraith wrote:
> > > > On Fri, 2021-06-25 at 12:08 -0400, John Kacur wrote:
> > > > > I'm pleased to announce rt-tests-2.0
> > > >
> > > > Greetings,
> > > >
> > > > cyclictest seems to have grown an mlock related regression.
> > >
> > > Ok, chores done, I did a quick bisect/confirm. I didn't go stare
> > > at rt_test_start() to ponder what the mlockall connection may be.
> >
> > Moving the call above "Get current time" stops it mucking things up.
>
> Thanks a lot for your excellent report. rt_test_start does
>
> static char ts_start[MAX_TS_SIZE];
>
> static void get_timestamp(char *tsbuf)
> {
> struct timeval tv;
> struct tm *tm;
> time_t t;
>
> gettimeofday(&tv, NULL);
> t = tv.tv_sec;
> tm = localtime(&t);
> /* RFC 2822-compliant date format */
> strftime(tsbuf, MAX_TS_SIZE, "%a, %d %b %Y %T %z", tm);
> }
>
> void rt_test_start(void)
> {
> get_timestamp(ts_start);
> }
>
> I'd say the tsbuf access is the one which triggers a pagefault.
>
> John, I would suggest to move the rt_test_start() into rt_init() and
> take the timestamp at the execution start (as my initial version was). I
> think the additional pain in slightly more correct start timestamp
> (which is also not defined what it actually means in this context) is
> just not worth the effort.
>
> Thanks,
> Daniel
>
Send me a patch, and I'll have a look. The timerthread()function is
sensitive anyway, so it's probably a good idea not to put that kind
of thing there.
Note that the the code following the /* Get Current Time */
is getting the time, but you probably want something rougher that
you can call strftime on?
John
next prev parent reply other threads:[~2021-06-28 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 16:08 [ANNOUNCE] rt-tests-2.0 John Kacur
2021-06-26 6:55 ` Mike Galbraith
2021-06-26 11:47 ` Mike Galbraith
2021-06-26 12:45 ` Mike Galbraith
2021-06-28 8:11 ` Daniel Wagner
2021-06-28 13:50 ` John Kacur [this message]
2021-06-28 14:13 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f31d9d37-df6d-90b0-8bf9-95156c27e8d@redhat.com \
--to=jkacur@redhat.com \
--cc=dwagner@suse.de \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=schwenderjonathan@gmail.com \
--cc=wagi@monom.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).