From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Emese Revfy <re.emese@gmail.com>
Cc: spender@grsecurity.net, keescook@chromium.org,
linux-kbuild@vger.kernel.org,
kernel-hardening@lists.openwall.com,
linux-kernel@vger.kernel.org, mmarek@suse.com,
pageexec@freemail.hu, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 3/3] powerpc: enable support for GCC plugins
Date: Wed, 7 Dec 2016 16:49:41 +1100 [thread overview]
Message-ID: <f32f62b8-dc38-6f0b-e7b7-1f85e504df5d@au1.ibm.com> (raw)
In-Reply-To: <20161206222520.7fb37896488eff1b299eb3db@gmail.com>
On 07/12/16 08:25, Emese Revfy wrote:
> What are these missing headers? Because if they aren't necessary then they can
> be removed from gcc-common.h. There were missing headers on arm/arm64 and these
> archs are supported. I think this version check is unnecessary because
> gcc-plugin.sh also checks the missing headers.
rs6000-cpus.def, included via tm.h - see
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66840
I realise gcc-plugin.sh does detect this, but the point of the
additional version check is to provide somewhat more helpful advice to
the user.
> What is the problem on gcc-4.5/gcc-4.6?
On 4.6.4, c-family/c-common.h:
/scratch/ajd/gcc-test-v2/kernel/scripts/gcc-plugins/gcc-common.h:60:31:
fatal error: c-family/c-common.h: No such file or directory
ajd@ka1:/scratch/ajd/tmp/cross/gcc-4.6.4-nolibc/powerpc64-linux$ find
-name c-common.*
./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-common.h
./lib/gcc/powerpc64-linux/4.6.4/plugin/include/c-family/c-common.def
Are we sure the version check in gcc-common.h:59 is correct, or is this
just a peculiarity of my particular toolchain?
I need to build another 4.5 toolchain, I'll try to do that this week.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2016-12-07 6:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 6:27 [PATCH 1/3] gcc-plugins: fix definition of DISABLE_LATENT_ENTROPY_PLUGIN Andrew Donnellan
2016-12-06 6:27 ` [PATCH 2/3] powerpc: correctly disable latent entropy GCC plugin on prom_init.o Andrew Donnellan
2016-12-06 6:28 ` [PATCH 3/3] powerpc: enable support for GCC plugins Andrew Donnellan
2016-12-06 20:40 ` Kees Cook
2016-12-07 1:05 ` [kernel-hardening] " Andrew Donnellan
2016-12-06 21:25 ` Emese Revfy
2016-12-07 5:49 ` Andrew Donnellan [this message]
2016-12-07 5:45 ` Andrew Donnellan
2016-12-08 14:42 ` PaX Team
2016-12-08 18:06 ` Kees Cook
2016-12-09 2:48 ` Andrew Donnellan
2016-12-09 10:59 ` PaX Team
2017-01-27 5:52 ` Andrew Donnellan
2017-01-27 5:55 ` Andrew Donnellan
2017-02-06 20:37 ` [1/3] gcc-plugins: fix definition of DISABLE_LATENT_ENTROPY_PLUGIN Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f32f62b8-dc38-6f0b-e7b7-1f85e504df5d@au1.ibm.com \
--to=andrew.donnellan@au1.ibm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmarek@suse.com \
--cc=pageexec@freemail.hu \
--cc=re.emese@gmail.com \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).