From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1EEC3A5A5 for ; Mon, 26 Aug 2019 06:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7503A217F4 for ; Mon, 26 Aug 2019 06:54:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="LCKeDRHY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729816AbfHZGy0 (ORCPT ); Mon, 26 Aug 2019 02:54:26 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39178 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729522AbfHZGyZ (ORCPT ); Mon, 26 Aug 2019 02:54:25 -0400 Received: by mail-wm1-f68.google.com with SMTP id i63so14673292wmg.4 for ; Sun, 25 Aug 2019 23:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LH8nuwe3bP13Yh7NeNLMzBxJFkFlumQfww0naVQY/ic=; b=LCKeDRHYsRuEnlvZBnUZvzlNwB9+uBMhgLw2RQRHMk469Bah+ulWs22MJkkPRZMWBq PXd2Nqlthk6llZ1Nlrf/ilqULuN0coVOGycDiu2ktGUfc3Pxq4V515Tf1V+BdifPZnBf a7yr+ohEiAnj4bsTimn9WVAFRkWQ4lFvKMdcS0yzkIJ6pH4lFcS/hDX3+1751Q5dKaqf TFuPAlhXMhrnP5xTxsvYNNPuRsrpW4HoVeXYXSt/3qWpniEpP63uLIQumqO/hiVDF5CA IaRCnNtpR0D7AusVR1jjWFPV+GmisgVxzdNRsEWzgYkZ148Az17Jebj1e2PpqR41m7vB eBzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LH8nuwe3bP13Yh7NeNLMzBxJFkFlumQfww0naVQY/ic=; b=HnvTx79ED8O5H0ZiiCqUQwKjn7v+7esx1onQSmp2GvAdA3iwSfbOC8Bzho+fbfixWE pfwK9CuErSep29qgzjSRkm0SaS6T+6x3KCE7U1NezsRBaEVl8X/p9wtaYa7KmZd8PlHL iKwFLd63mAPC/k/zK72ZITfIuq5weTM4OkiRVN849LFLxgufNLwQr0g85lUGLvnaCjDA JUN1EVDjrD73TWjex2DOpMdAvYImv1wgk2MeZCr04CUmBqpZk38OyflQeF1ABF/4AFFJ zltq/x2KS8LtOd3ANZZ+vVLyzRrtnnrOWLepI6a2k4lc64sLo3HUHohwfZNy31adZKhT cWBA== X-Gm-Message-State: APjAAAWpfphi5SUwZXrXoCEBD64kjxg6Dmmq8WKFrgRFRDEfENSKZM/9 0RDqPq7ijN6oNV2Vp+h989tLAQ== X-Google-Smtp-Source: APXvYqxt1jP0j8SrYkUtzWli7NAQFzABzPzsKaH1f6iL2LCqMpOvb1zMBOdbwIM4e7gPbL/kITthQQ== X-Received: by 2002:a7b:c7cb:: with SMTP id z11mr18346191wmk.24.1566802462979; Sun, 25 Aug 2019 23:54:22 -0700 (PDT) Received: from [192.168.1.6] (124.red-83-36-179.dynamicip.rima-tde.net. [83.36.179.124]) by smtp.gmail.com with ESMTPSA id g26sm11091714wmh.32.2019.08.25.23.54.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Aug 2019 23:54:22 -0700 (PDT) Subject: Re: [PATCH v4 00/13] Support CPU frequency scaling on QCS404 To: bjorn.andersson@linaro.org, sboyd@kernel.org, david.brown@linaro.org, jassisinghbrar@gmail.com, mark.rutland@arm.com, mturquette@baylibre.com, robh+dt@kernel.org, will.deacon@arm.com, arnd@arndb.de, horms+renesas@verge.net.au, heiko@sntech.de, sibis@codeaurora.org, enric.balletbo@collabora.com, jagan@amarulasolutions.com, olof@lixom.net Cc: vkoul@kernel.org, niklas.cassel@linaro.org, georgi.djakov@linaro.org, amit.kucheria@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, khasim.mohammed@linaro.org References: <20190731202929.16443-1-jorge.ramirez-ortiz@linaro.org> From: Jorge Ramirez Message-ID: Date: Mon, 26 Aug 2019 08:54:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190731202929.16443-1-jorge.ramirez-ortiz@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/31/19 22:29, Jorge Ramirez-Ortiz wrote: > The following patchset enables CPU frequency scaling support on the > QCS404 (with dynamic voltage scaling). > > It is important to notice that this functionality will be superseded > by Core Power Reduction (CPR), a more accurate form of AVS found on > certain Qualcomm SoCs. > > Some of the changes required to support CPR do conflict with the > configuration required for CPUFreq. > > In particular, the following commit for CPR - already merged - will > need to be reverted in order to enable CPUFreq. > > Author: Jorge Ramirez-Ortiz > Date: Thu Jul 25 12:41:36 2019 +0200 > cpufreq: Add qcs404 to cpufreq-dt-platdev blacklist > > Patch 8 "clk: qcom: hfpll: CLK_IGNORE_UNUSED" is a bit controversial; > in this platform, this PLL provides the clock signal to a CPU > core. But in others it might not. > > We opted for the minimal ammount of changes without affecting the > default functionality: simply bypassing the COMMON_CLK_DISABLE_UNUSED > framework and letting the firwmare chose whether to enable or disable > the clock at boot. However maybe a DT property and marking the clock > as critical would be more appropriate for this PLL. we'd appreciate the > maintainer's input on this topic. > > v2: > - dts: ms8916: apcs mux/divider: new bindings > (the driver can still support the old bindings) > > - qcs404.dtsi > fix apcs-hfpll definition > fix cpu_opp_table definition > > - GPLL0_AO_OUT operating frequency > define new alpha_pll_fixed_ops to limit the operating frequency > > v3: > - qcom-apcs-ipc-mailbox > replace goto to ease readability > > - apcs-msm8916.c > rework patch to use of_clk_parent_fill > > - hfpll.c > add relevant comments to the code > > - qcs404.dtsi > add voltage scaling support > > v4: > - squash OPP definition and DVFS enablement in dts > (patches 10 and 13 in previous version) > > - qcom-apcs-ipc-mailbox > replace return condition for readability > > - answer one question on CLK_IGNORE_UNUSED in mailing list > > Jorge Ramirez-Ortiz, Niklas Cassel (13): > clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency > mbox: qcom: add APCS child device for QCS404 > mbox: qcom: replace integer with valid macro > dt-bindings: mailbox: qcom: Add clock-name optional property > clk: qcom: apcs-msm8916: get parent clock names from DT > clk: qcom: hfpll: get parent clock names from DT > clk: qcom: hfpll: register as clock provider > clk: qcom: hfpll: CLK_IGNORE_UNUSED > arm64: dts: qcom: msm8916: Add the clocks for the APCS mux/divider > arm64: dts: qcom: qcs404: Add HFPLL node > arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider > arm64: dts: qcom: qcs404: Add DVFS support > arm64: defconfig: Enable HFPLL > > .../mailbox/qcom,apcs-kpss-global.txt | 24 +++++++++-- > arch/arm64/boot/dts/qcom/msm8916.dtsi | 3 +- > arch/arm64/boot/dts/qcom/qcs404.dtsi | 43 +++++++++++++++++++ > arch/arm64/configs/defconfig | 1 + > drivers/clk/qcom/apcs-msm8916.c | 23 ++++++++-- > drivers/clk/qcom/clk-alpha-pll.c | 8 ++++ > drivers/clk/qcom/clk-alpha-pll.h | 1 + > drivers/clk/qcom/gcc-qcs404.c | 2 +- > drivers/clk/qcom/hfpll.c | 25 ++++++++++- > drivers/mailbox/qcom-apcs-ipc-mailbox.c | 11 +++-- > 10 files changed, 128 insertions(+), 13 deletions(-) > any feedback on this set? TIA