From: skakit@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <agross@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
mka@chromium.org, kgunda@codeaurora.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver
Date: Wed, 08 Sep 2021 14:47:37 +0530 [thread overview]
Message-ID: <f35822d036988a1a6b6e4dcaa46373e7@codeaurora.org> (raw)
In-Reply-To: <CAE-0n52Jb9nw9rbbQJrKNDQ_O2iCahDr8WLGkWORcNks9ptH-g@mail.gmail.com>
On 2021-09-08 01:50, Stephen Boyd wrote:
> Quoting satya priya (2021-09-06 03:41:06)
>> Add pm8350c compatible and lpg_data to the driver.
>>
>> Signed-off-by: satya priya <skakit@codeaurora.org>
>> ---
>> drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c
>> b/drivers/leds/rgb/leds-qcom-lpg.c
>> index 327e81a..6ee80d6 100644
>> --- a/drivers/leds/rgb/leds-qcom-lpg.c
>> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
>> @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data =
>> {
>> },
>> };
>>
>> +static const struct lpg_data pm8350c_pwm_data = {
>> + .pwm_9bit_mask = BIT(2),
>> +
>> + .num_channels = 1,
>> + .channels = (struct lpg_channel_data[]) {
>
> Can this be const struct lpg_channel_data? I think that will move it to
> rodata which is only a good thing.
>
I agree.
@Bjorn, can we make it const struct?
>> + { .base = 0xeb00 },
>> + },
>> +};
>> +
>> static const struct of_device_id lpg_of_table[] = {
>> { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data
>> },
>> { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data
>> },
>> + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data
>> },
>> { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data },
>> { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data },
>> { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data },
next prev parent reply other threads:[~2021-09-08 9:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 10:41 [PATCH 0/3] Add PM8350C PMIC PWM support for backlight satya priya
2021-09-06 10:41 ` [PATCH 1/3] dt-bindings: leds: Add pm8350c pmic support satya priya
2021-09-07 17:48 ` Matthias Kaehlcke
2021-09-07 20:03 ` Stephen Boyd
2021-09-08 13:52 ` Rob Herring
2021-09-06 10:41 ` [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver satya priya
2021-09-07 17:54 ` Matthias Kaehlcke
2021-09-07 17:58 ` Matthias Kaehlcke
2021-09-07 18:02 ` Matthias Kaehlcke
2021-09-07 20:20 ` Stephen Boyd
2021-09-08 9:17 ` skakit [this message]
2021-09-08 17:11 ` Bjorn Andersson
2021-09-06 10:41 ` [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support satya priya
2021-09-07 18:16 ` Matthias Kaehlcke
2021-09-08 9:07 ` skakit
2021-09-08 15:29 ` Matthias Kaehlcke
2021-09-08 17:08 ` Bjorn Andersson
2021-09-09 6:11 ` skakit
2021-09-08 3:34 ` Stephen Boyd
2021-09-08 9:14 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f35822d036988a1a6b6e4dcaa46373e7@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mka@chromium.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).