From: <Codrin.Ciubotariu@microchip.com>
To: <Nicolas.Ferre@microchip.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <richard.genoud@gmail.com>,
<lee.jones@linaro.org>
Cc: <alexandre.belloni@bootlin.com>, <Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91: add serial MFD sub-node for usart
Date: Fri, 30 Oct 2020 14:24:24 +0000 [thread overview]
Message-ID: <f370bbf7-5cfc-1524-8103-061698ba6b67@microchip.com> (raw)
In-Reply-To: <b054ce5c-58fd-dd86-2cb6-1e1f06a0899e@microchip.com>
On 30.10.2020 15:38, Nicolas Ferre wrote:
> On 30/10/2020 at 12:07, Codrin Ciubotariu wrote:
>> The "atmel,at91sam9260-usart" driver is a MFD driver, so it needs
>> sub-nodes
>> to match the registered platform device. For this reason, we add a serial
>> subnode to all the "atmel,at91sam9260-usart" serial compatible nods. This
>> will also remove the boot warning:
>> "atmel_usart_serial: Failed to locate of_node [id: -2]"
>
> I don't remember this warning was raised previously even if the MFD
> driver was added a while ago (Sept. 2018).
>
> I would say it's due to 466a62d7642f ("mfd: core: Make a best effort
> attempt to match devices with the correct of_nodes") which was added on
> mid August and corrected with 22380b65dc70 ("mfd: mfd-core: Ensure
> disabled devices are ignored without error") but maybe not covering our
> case.
Well, it's not covering our enabled devices.
>
> So, well, I don't know what's the best option to this change. Moreover,
> I would say that all other USART related properties go into the child
> not if there is a need for one.
>
> Lee, I suspect that we're not the only ones experiencing this ugly
> warning during the boot log: can you point us out how to deal with it
> for our existing atmel_serial.c users?
My understading is that platform devices registered by MFD should have a
correspondig DT node. The parrent properties are also available for the
other usart device (usart-spi), so I think we should keep them in the
parrent.
Best regards,
Codrin
next prev parent reply other threads:[~2020-10-30 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 11:07 [PATCH] ARM: dts: at91: add serial MFD sub-node for usart Codrin Ciubotariu
2020-10-30 13:38 ` Nicolas Ferre
2020-10-30 14:24 ` Codrin.Ciubotariu [this message]
2020-11-02 9:07 ` Lee Jones
2020-11-02 12:41 ` Codrin.Ciubotariu
2020-11-02 9:01 ` Lee Jones
2020-11-02 12:11 ` Codrin.Ciubotariu
2020-11-02 12:29 ` Lee Jones
2020-11-02 12:55 ` Codrin.Ciubotariu
2020-11-02 16:56 ` Codrin.Ciubotariu
2020-11-03 8:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f370bbf7-5cfc-1524-8103-061698ba6b67@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).