From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbcHANPF (ORCPT ); Mon, 1 Aug 2016 09:15:05 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35843 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752843AbcHANPD (ORCPT ); Mon, 1 Aug 2016 09:15:03 -0400 Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than duplicating its implementation To: "Deucher, Alexander" , "'Sean Paul'" , Wei Yongjun References: <1469722697-15220-1-git-send-email-weiyj.lk@gmail.com> Cc: "Nath, Arindam" , "Zhou, Jammy" , Linux Kernel Mailing List , dri-devel , "Jiang, Sonny" , "Liu, Leo" , "Koenig, Christian" , "Liu, Monk" From: =?UTF-8?Q?Nicolai_H=c3=a4hnle?= Message-ID: Date: Mon, 1 Aug 2016 13:16:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.07.2016 20:38, Deucher, Alexander wrote: >> -----Original Message----- >> From: Sean Paul [mailto:seanpaul@google.com] >> Sent: Friday, July 29, 2016 3:35 PM >> To: Wei Yongjun >> Cc: Deucher, Alexander; Koenig, Christian; Dave Airlie; Jiang, Sonny; Liu, Leo; >> Nath, Arindam; Zhou, David(ChunMing); Zhou, Jammy; Liu, Monk; dri-devel; >> Linux Kernel Mailing List >> Subject: Re: [PATCH -next] drm/amdgpu: use kmemdup rather than >> duplicating its implementation >> >> On Thu, Jul 28, 2016 at 12:18 PM, Wei Yongjun wrote: >>> Use kmemdup rather than duplicating its implementation. >>> >>> Generated by: scripts/coccinelle/api/memdup.cocci >>> >>> Signed-off-by: Wei Yongjun >> >> >> Thanks for the patch. I'll apply this to -misc once the merge window is closed. >> >> Acked-by: Sean Paul > > Unless you've already applied this to the misc tree, I'd prefer to take it via the amdgpu tree. I recall Christian NAKing an almost identical patch some time ago. Something about needing memcpy_fromio()? Yup, it's here: https://lkml.org/lkml/2016/5/19/235 Cheers, Nicolai > > Alex > >> >> >>> --- >>> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c >>> index a46a64c..b779b5f 100644 >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c >>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c >>> @@ -296,12 +296,10 @@ int amdgpu_uvd_suspend(struct amdgpu_device >> *adev) >>> size = amdgpu_bo_size(adev->uvd.vcpu_bo); >>> ptr = adev->uvd.cpu_addr; >>> >>> - adev->uvd.saved_bo = kmalloc(size, GFP_KERNEL); >>> + adev->uvd.saved_bo = kmemdup(ptr, size, GFP_KERNEL); >>> if (!adev->uvd.saved_bo) >>> return -ENOMEM; >>> >>> - memcpy(adev->uvd.saved_bo, ptr, size); >>> - >>> return 0; >>> } >>> >>> >>> >>> > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel >