* [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE
@ 2021-04-13 12:21 Geert Uytterhoeven
2021-04-27 11:07 ` Hector Martin
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-04-13 12:21 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Hector Martin
Cc: Will Deacon, linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The Apple Interrupt Controller is only present on Apple Silicon SoCs.
Hence add a dependency on ARCH_APPLE, to prevent asking the user about
this driver when configuring a kernel without Apple Silicon SoC support.
Drop the default, as ARCH_APPLE already selects APPLE_AIC.
Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple Interrupt Controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/irqchip/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index d3a14f304ec80caa..b165b3285d9b0555 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -580,7 +580,7 @@ config MST_IRQ
config APPLE_AIC
bool "Apple Interrupt Controller (AIC)"
depends on ARM64
- default ARCH_APPLE
+ depends on ARCH_APPLE || COMPILE_TEST
help
Support for the Apple Interrupt Controller found on Apple Silicon SoCs,
such as the M1.
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE
2021-04-13 12:21 [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE Geert Uytterhoeven
@ 2021-04-27 11:07 ` Hector Martin
2021-04-27 12:36 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Hector Martin @ 2021-04-27 11:07 UTC (permalink / raw)
To: Geert Uytterhoeven, Thomas Gleixner, Marc Zyngier
Cc: Will Deacon, linux-arm-kernel, linux-kernel
On 13/04/2021 21.21, Geert Uytterhoeven wrote:
> The Apple Interrupt Controller is only present on Apple Silicon SoCs.
> Hence add a dependency on ARCH_APPLE, to prevent asking the user about
> this driver when configuring a kernel without Apple Silicon SoC support.
>
> Drop the default, as ARCH_APPLE already selects APPLE_AIC.
>
> Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple Interrupt Controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/irqchip/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Makes sense. Thanks!
Acked-by: Hector Martin <marcan@marcan.st>
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE
2021-04-27 11:07 ` Hector Martin
@ 2021-04-27 12:36 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2021-04-27 12:36 UTC (permalink / raw)
To: Hector Martin
Cc: Geert Uytterhoeven, Thomas Gleixner, Will Deacon,
linux-arm-kernel, linux-kernel
On 2021-04-27 12:07, Hector Martin wrote:
> On 13/04/2021 21.21, Geert Uytterhoeven wrote:
>> The Apple Interrupt Controller is only present on Apple Silicon SoCs.
>> Hence add a dependency on ARCH_APPLE, to prevent asking the user about
>> this driver when configuring a kernel without Apple Silicon SoC
>> support.
>>
>> Drop the default, as ARCH_APPLE already selects APPLE_AIC.
>>
>> Fixes: 76cde26394114f6a ("irqchip/apple-aic: Add support for the Apple
>> Interrupt Controller")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>> drivers/irqchip/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>
> Makes sense. Thanks!
>
> Acked-by: Hector Martin <marcan@marcan.st>
I'll pick this up post -rc1.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-27 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 12:21 [PATCH] irqchip: APPLE_AIC should depend on ARCH_APPLE Geert Uytterhoeven
2021-04-27 11:07 ` Hector Martin
2021-04-27 12:36 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).