From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v2 6/6] serial: exar: Add support for IOT2040 device
Date: Thu, 18 May 2017 18:58:02 +0200 [thread overview]
Message-ID: <f3959f33-b82a-e64a-c04d-bfa7ab486402@siemens.com> (raw)
In-Reply-To: <65189e05-e300-bbe3-660d-4fdd6d4ec8c1@siemens.com>
On 2017-05-18 18:39, Jan Kiszka wrote:
> On 2017-05-18 18:33, Andy Shevchenko wrote:
>> On Thu, May 18, 2017 at 5:59 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>>> This implements the setup of RS232 and the switch-over to RS485 or RS422
>>> for the Siemens IOT2040. That uses an EXAR XR17V352 with external logic
>>> to switch between the different modes. The external logic is controlled
>>> via MPIO pins of the EXAR controller.
>>>
>>> Only pin 10 can be exported as GPIO on the IOT2040. It is connected to
>>> an LED.
>>>
>>> As the XR17V352 used on the IOT2040 is not equipped with an external
>>> EEPROM, it cannot present itself as IOT2040-variant via subvendor/
>>> subdevice IDs. Thus, we have to check via DMI for the target platform.
>>>
>>> Co-developed with Sascha Weisenberger.
>>
>> Few nits below and one comment that should be addressed.
>>
>>> +#define UART_EXAR_RS485_DLY(x) (x << 4)
>>
>> ((x) << 4)
>
> Yep.
>
>>
>>> +static bool is_iot2040;
>>
>> No, please, use driver data of DMI and hide this in corresponding structure.
>> Or even assign port->port.rs485_config in the callback function.
>>
>> Moreover, can't you use port->port.rs485_config != NULL instead?
>
> There are two cases to be handled on IOT2040: the setting of the
> rs485_config and the different setup of the GPIOs, but the latter at a
> specific point in the initialization only. So I don't see yet how
> driver_data could come into play and help.
>
OK, got - hacking...
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-05-18 16:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:59 [PATCH v2 0/6] serial/gpio: exar: Fixes and support for IOT2000 Jan Kiszka
2017-05-18 14:59 ` [PATCH v2 1/6] gpio: exar: Fix passing in of parent PCI device Jan Kiszka
2017-05-18 17:14 ` Andy Shevchenko
2017-05-21 11:44 ` Jan Kiszka
2017-05-22 15:43 ` Linus Walleij
2017-05-18 14:59 ` [PATCH v2 2/6] gpio: exar: Allocate resources on behalf of the platform device Jan Kiszka
2017-05-18 14:59 ` [PATCH v2 3/6] gpio: exar: Fix iomap request Jan Kiszka
2017-05-18 14:59 ` [PATCH v2 4/6] gpio: exar: Fix reading of directions and values Jan Kiszka
2017-05-18 15:28 ` Andy Shevchenko
2017-05-18 14:59 ` [PATCH v2 5/6] gpio-exar/8250-exar: Make set of exported GPIOs configurable Jan Kiszka
2017-05-18 17:43 ` Andy Shevchenko
2017-05-21 11:43 ` Jan Kiszka
2017-05-22 16:33 ` Andy Shevchenko
2017-05-22 17:04 ` Jan Kiszka
2017-05-22 15:44 ` Linus Walleij
2017-05-18 14:59 ` [PATCH v2 6/6] serial: exar: Add support for IOT2040 device Jan Kiszka
2017-05-18 16:33 ` Andy Shevchenko
2017-05-18 16:39 ` Jan Kiszka
2017-05-18 16:58 ` Jan Kiszka [this message]
2017-05-18 17:23 ` Jan Kiszka
2017-05-18 17:41 ` Andy Shevchenko
2017-05-22 15:46 ` Linus Walleij
2017-05-22 16:28 ` Jan Kiszka
2017-05-22 16:34 ` Andy Shevchenko
2017-05-22 16:40 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3959f33-b82a-e64a-c04d-bfa7ab486402@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=andy.shevchenko@gmail.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sascha.weisenberger@siemens.com \
--cc=sudip.mukherjee@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).