From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85D7BC61DA4 for ; Thu, 26 Jan 2023 13:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236044AbjAZNDG (ORCPT ); Thu, 26 Jan 2023 08:03:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbjAZNDE (ORCPT ); Thu, 26 Jan 2023 08:03:04 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E35DA274; Thu, 26 Jan 2023 05:02:58 -0800 (PST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30QCvXaa025500; Thu, 26 Jan 2023 13:02:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : to : cc : references : from : subject : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=x2zmArNo6Y7grLIZvlBbSayXM/yP7uDyVit9C8eQoY8=; b=KLblHCjlBgdanaYXHa6eTrEIP0ibAj0R1xlnKHAoovIdLjWEbThidcXM9KiG8gvDWy2x k15r6+tm58yPjBDc6dc2/8rv2d9eLkw8BRQM2YK2u6DSWp6SQpgsLZUgUf3J3fBc9qba aM/g4N2ajlk1yiT+xeo8KxKLIuWKx5ow3hBLfMNpzP9P3eox7RIvQB5RKVceFTrpE0my eX41/o5g3ZFllloq011R96tTTHvQ2v6wE9tBo5kkcipWiFMA6woQbE71Qg9u9WIhwttN BegoKPhKplLQ/Xe4+ND/odbNrET2e7gzDcsq9nUmBweATBRZ2K7d3tVxAUc4uQ9e6r10 IQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nbsymr4mg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Jan 2023 13:02:54 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30QD0KfQ002383; Thu, 26 Jan 2023 13:02:53 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nbsymr4ka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Jan 2023 13:02:53 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30QB966G026765; Thu, 26 Jan 2023 13:02:51 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3n87p6ee1g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Jan 2023 13:02:50 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30QD2lKg24314404 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Jan 2023 13:02:47 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 500B62004B; Thu, 26 Jan 2023 13:02:47 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 144C820040; Thu, 26 Jan 2023 13:02:47 +0000 (GMT) Received: from [9.152.224.253] (unknown [9.152.224.253]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 26 Jan 2023 13:02:47 +0000 (GMT) Message-ID: Date: Thu, 26 Jan 2023 14:02:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: Thomas Huth , Janis Schoetterl-Glausch , Christian Borntraeger , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev Cc: David Hildenbrand , Jonathan Corbet , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sven Schnelle References: <20230125212608.1860251-1-scgl@linux.ibm.com> <20230125212608.1860251-11-scgl@linux.ibm.com> <6594a21f-6372-0b69-3bb3-6ed1b1387e6e@redhat.com> From: Janosch Frank Subject: Re: [PATCH v6 10/14] KVM: s390: Refactor absolute vm mem_op function In-Reply-To: <6594a21f-6372-0b69-3bb3-6ed1b1387e6e@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: iALh7UywSKEmPegeU3NvlBr7s7-ERvHu X-Proofpoint-ORIG-GUID: QDDABgO6tZ-_aCKwZiAMfa73ZLi_ep6V X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_05,2023-01-25_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=629 spamscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301260126 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/26/23 13:18, Thomas Huth wrote: > On 25/01/2023 22.26, Janis Schoetterl-Glausch wrote: >> Remove code duplication with regards to the CHECK_ONLY flag. >> Decrease the number of indents. >> No functional change indented. >> >> Suggested-by: Janosch Frank >> Signed-off-by: Janis Schoetterl-Glausch >> --- >> >> >> Cosmetic only, can be dropped. > > I'm torn between unnecessary-code-churn and > nice-to-get-rid-of-one-indentation-level here ... anyway, patch looks sane > to me, so: > > Reviewed-by: Thomas Huth > As long as we're not adding to this function in the future then I'm okish with leaving it as is.