From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA69FC55185 for ; Sat, 25 Apr 2020 23:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7FF22071E for ; Sat, 25 Apr 2020 23:44:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="AdwbSH1Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726233AbgDYXoZ (ORCPT ); Sat, 25 Apr 2020 19:44:25 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:5866 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726070AbgDYXoX (ORCPT ); Sat, 25 Apr 2020 19:44:23 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sat, 25 Apr 2020 16:42:24 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Sat, 25 Apr 2020 16:44:23 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Sat, 25 Apr 2020 16:44:23 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr 2020 23:44:23 +0000 Received: from [10.2.165.152] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 25 Apr 2020 23:44:21 +0000 Subject: Re: [RFC PATCH v10 6/9] media: tegra: Add Tegra210 Video input driver To: Dmitry Osipenko , , , , , , CC: , , , , , References: <1587700513-28449-1-git-send-email-skomatineni@nvidia.com> <1587700513-28449-7-git-send-email-skomatineni@nvidia.com> <3155e0d2-94b0-6e0a-bf35-b3560c201039@gmail.com>

<6568af00-3d65-4ddb-f003-7a4161d751a0@gmail.com> From: Sowjanya Komatineni Message-ID: Date: Sat, 25 Apr 2020 16:44:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <6568af00-3d65-4ddb-f003-7a4161d751a0@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1587858144; bh=PiLaNp0bCg78WuOfTnePbhKvbw4eCJtNxZvWa9U+pnU=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=AdwbSH1QFw17nP9MW9B5o3x1LamyxnSbGvN0/w7vkDa/x9uOMnarvSZxFTCBmeFYD k6nMwRjbqav+w4LRL3Sy/UXQtsVb5idRSRi9XleV0oKqrd21v8+cAZxwc4buphC6wt bHxIcf/OCIzdhhFCN/ynnBAILZoAFNlnROlxoKgjykJerg8SW6qq4Q8yI1QzikKf3a unFtMejpr1pGtvxGcnSF0rLKxP2jFE4wi30irOW6HDd9VIAZdbOertvlIqrC/VOR1+ BGkW4eKz7yBBTCBoTGgHShDahJZ5ZbPxda22PfLvgg9By/Bg7gDpOrHEbZjwi5r8u7 xJe3ApYVBquIQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/25/20 4:40 PM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 26.04.2020 01:11, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> On 4/25/20 3:08 PM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 25.04.2020 01:00, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>> On 4/24/20 8:07 AM, Dmitry Osipenko wrote: >>>>> External email: Use caution opening links or attachments >>>>> >>>>> >>>>> 24.04.2020 06:55, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>>>> >>>>> Is this driver compiled as a single kernel module file? >>>>> >>>>>> +MODULE_AUTHOR("Sowjanya Komatineni "); >>>>>> +MODULE_DESCRIPTION("NVIDIA Tegra CSI Device Driver"); >>>>>> +MODULE_LICENSE("GPL v2"); >>>>> ... >>>>>> +MODULE_AUTHOR("Sowjanya Komatineni "); >>>>>> +MODULE_DESCRIPTION("NVIDIA Tegra Video Input Device Driver"); >>>>>> +MODULE_LICENSE("GPL v2"); >>>>> I don't think that these macros are needed in that case. >>>>> The video.c should be enough, isn't it? >>>> yes these can be removed >>> It will be nice to factor out the Tegra210-specific VI/CSI OPS into a >>> separate driver module (say tegra210-vi) to ease supporting of other >>> Tegra versions. Of course this could be done later on, although I >>> suppose the amount of hassle could be reduced if it's done from the >>> start. >> vi/csi.c are common drivers for all Tegras. All Tegra chip specific >> related programming for both vi and csi were already moved to Tegra210.c >> based on prior feedbacks. > Judging by the code's structure the VI/CSI drivers aren't planned to be > reused by older pre-Terga210 SoCs, correct? > > How much of the T210 code could be reused by T186/194? vi/csi are common driver where soc structure should be populated for=20 T186/T194 Tegra210.c can't be reused for Tegra186/t194 as programming seq is a=20 whole lot diff