From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751955AbdC1MJw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Mar 2017 08:09:52 -0400
Received: from mail-pg0-f46.google.com ([74.125.83.46]:34903 "EHLO
        mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751547AbdC1MJu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Mar 2017 08:09:50 -0400
Subject: Re: [PATCH v3 3/3] perf annotate: Fix missing number of samples
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
References: <1490598638-13947-1-git-send-email-treeze.taeung@gmail.com>
 <1490598638-13947-4-git-send-email-treeze.taeung@gmail.com>
 <20170327182631.GC27431@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <f3a7d217-977b-115e-5313-8e0707182b60@gmail.com>
Date: Tue, 28 Mar 2017 21:09:44 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20170327182631.GC27431@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Good morning, Arnaldo :)

On 03/28/2017 03:26 AM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Mar 27, 2017 at 04:10:38PM +0900, Taeung Song escreveu:
>> If running 'perf annotate --stdio -l --show-total-period',
>> you can see a problem showing only zero '0' for number of samples.
>>
>> Before:
>>     $ perf annotate --stdio -l --show-total-period
>> ...
>>        0 :        400816:       push   %rbp
>>        0 :        400817:       mov    %rsp,%rbp
>>        0 :        40081a:       mov    %edi,-0x24(%rbp)
>>        0 :        40081d:       mov    %rsi,-0x30(%rbp)
>>        0 :        400821:       mov    -0x24(%rbp),%eax
>>        0 :        400824:       mov    -0x30(%rbp),%rdx
>>        0 :        400828:       mov    (%rdx),%esi
>>        0 :        40082a:       mov    $0x0,%edx
>> ...
>>
>> The reason is number of samples aren't set
>> in symbol__get_source_line(). so set it ordinarily.
>
> Can you please take a look at:
>
>   0c4a5bcea460 ("perf annotate: Display total number of samples with --show-total-period")
>
> that introduced the --show-total-period code and take it into account in
> this fix?
>
> I.e. from a quick look it did the calculation setting that field in the
> TUI code, where it should have done in the util/annotate.c file, so that
> all UIs would be able to use it.
>
> After your analysis, please add a Fixes: that cset, ok?
>
> I applied the other two patches and added Martin to the CC list, as he
> is the author of that patch and may have something to say here.
>
> - Arnaldo
>

Okey! I look into the cset 0c4a5bcea460.

It is fine but if running 'show-total-period' with '-l',
the problem happen. The reason is to miss setting number of samples
for source_line_samples, so will send v4 added Fixes: and Cc: Martin
(and a bit changed commit log message)

Thanks,
Taeung