From: Tyler Baicar <tbaicar@codeaurora.org>
To: Dongdong Liu <liudongdong3@huawei.com>,
rjw@rjwysocki.net, tony.luck@intel.com, bp@alien8.de, bp@suse.de,
will.deacon@arm.com, james.morse@arm.com,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <helgaas@kernel.org>
Subject: Re: [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity
Date: Mon, 13 Nov 2017 10:34:58 -0500 [thread overview]
Message-ID: <f3baa5eb-a7fa-9654-99b6-81dadb6df938@codeaurora.org> (raw)
In-Reply-To: <cbcfe70b-e74f-ca1d-b58d-a8b1c391a91b@huawei.com>
On 11/13/2017 7:36 AM, Dongdong Liu wrote:
>
> 在 2017/11/9 3:13, Tyler Baicar 写道:
>> Currently the GHES code only calls into the AER driver for
>> recoverable type errors. This is incorrect because errors of
>> other severities do not get logged by the AER driver and do not
>> get exposed to user space via the AER trace event. So, call
>> into the AER driver for PCIe errors regardless of the severity
>
> It will also call do_recovery() regardless of the severity for AER correctable
> errors.
> Correctable errors include those error conditions where hardware can recover
> without any loss of information.
> Hardware corrects these errors and software intervention is not required.
> So we'd better modify the code as below.
> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
> b/drivers/pci/pcie/aer/aerdrv_core.c
> index 7448052..a7f77549 100644
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -633,7 +633,8 @@ static void aer_recover_work_func(struct work_struct *work)
> continue;
> }
> cper_print_aer(pdev, entry.severity, entry.regs);
> - do_recovery(pdev, entry.severity);
> + if(entry.severity != AER_CORRECTABLE)
> + do_recovery(pdev, entry.severity);
> pci_dev_put(pdev);
> }
> }
Hello Dongdong,
Yes, I have a patch for this that needs to be picked up.
https://lkml.org/lkml/2017/8/28/848
Thanks,
Tyler
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-11-13 15:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 19:13 [PATCH 0/2] Restructure and fix GHES PCIe AER handling Tyler Baicar
2017-11-08 19:13 ` [PATCH 1/2] acpi: apei: handle PCIe AER errors in separate function Tyler Baicar
2017-11-09 17:21 ` Borislav Petkov
2017-11-08 19:13 ` [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity Tyler Baicar
2017-11-09 9:46 ` Borislav Petkov
2017-11-09 14:37 ` Tyler Baicar
2017-11-09 15:01 ` Borislav Petkov
2017-11-09 15:14 ` Tyler Baicar
2017-11-09 17:29 ` Borislav Petkov
2017-11-13 12:36 ` Dongdong Liu
2017-11-13 15:34 ` Tyler Baicar [this message]
2017-11-15 15:14 Tyler Baicar
2017-11-18 14:54 ` Rafael J. Wysocki
2017-11-28 10:57 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3baa5eb-a7fa-9654-99b6-81dadb6df938@codeaurora.org \
--to=tbaicar@codeaurora.org \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=helgaas@kernel.org \
--cc=james.morse@arm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).