From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932880AbcFGSsH (ORCPT ); Tue, 7 Jun 2016 14:48:07 -0400 Received: from mail-bl2on0057.outbound.protection.outlook.com ([65.55.169.57]:9549 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932119AbcFGSsF (ORCPT ); Tue, 7 Jun 2016 14:48:05 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-353ff70000000bcf-8a-57571246e18e Subject: Re: [RFC] IB/srp: Remove create_workqueue To: Bhaktipriya Shridhar , Bart Van Assche , Doug Ledford , Sean Hefty , Hal Rosenstock References: <20160607181617.GA6556@Karyakshetra> CC: Tejun Heo , , From: Bart Van Assche Message-ID: Date: Tue, 7 Jun 2016 11:32:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160607181617.GA6556@Karyakshetra> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42JZI8azSNdDKDzcYNsBE4s3P6YyWrw8/4HV YuPmiYwWl3fNYbN4dqiXxaJ5/QYWi1/LjzI6sHvsnHWX3WPxnpdMHptWdbJ5vN93lc3j8ya5 ANYoLpuU1JzMstQifbsEroy2/z/ZC2ayVdx4epe9gbGJtYuRk0NCwETizN6tTF2MXBxCAnOZ JK6dXwXlbGeUONl0hQWmavOKS8wQiaWMEi/7l7F3MXJwCAsYSZx8qQoSFxG4xijR+ekMWIOQ gIHEru19YDazQKzExvVvwWw2oPpv72eC2bwCdhJLdrSzg9gsAioSvY9+gp0kKhAh8en3F1aI GkGJkzOfsIDs4hQwlPi52ALEZBawl3iwtQxiurzE9rdzwE6TELjKKtF0spkN4gR1iZNL5jNN YBSehWTSLIT2WUjaFzAyr2IUy83MKc5NTy0wNNUrTsxLySzO1kvOz93ECImXzB2Md594H2IU 4GBU4uHd8SU0XIg1say4MvcQowQHs5II73ye8HAh3pTEyqrUovz4otKc1OJDjNIcLErivG73 voQJCaQnlqRmp6YWpBbBZJk4OKUaGLf+Wyv5KjjdcxdTis3aSyzy5ye/fi9itOXKKgddHbGI hPMC/rvOdR6c231p7aQZ59I0pWfce5CzeuLki0bLVN+qHcqvKLm9wqyNV4Y3nEGw9s8xhzWu aq6NLj91Sq5XaG/r315fwNjLNWsyX069jJ+Pv9BNu527fvxqT7Pir2t7bcCm2Nl4UImlOCPR UIu5qDgRANtFUFCTAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgluLIzCtJLcpLzFFi42Lh2siRousrHB5usOcTr8XBn22MFm9+TGW0 eHn+A6vFxs0TGS0u75rDZvHsUC+LRfP6DSwWv5YfZXTg8Ng56y67x+I9L5k8Nq3qZPN4v+8q m8e0NeeZPD5vkgtgi+KySUnNySxLLdK3S+DKaPv/k71gJlvFjad32RsYm1i7GDk5JARMJDav uMTcxcjFISSwmFGiZeMWti5GDg5hASOJky9VQWpEBG4wSvx6awpiCwkYSOza3scCYjMLREq8 Wt0MZrMBlX97PxPM5hWwk1iyo50dxGYRUJHoffQTbJeoQITEp99fWCFqBCVOznzCArKKU8BQ 4udiC4iRthJ35u5mhrDlJba/ncM8gZFvFpKOWUjKZiEpW8DIvIpRLDczpzg3PbPA0EivODEv JbM4Wy85P3cTIziMOaN2MF6faH6IkYmDU6qBkeVtWP7mF9w9tUeSnJW2TzXPfChb5nvqiaRW wx1+N/PCpu8sj3aISf3ptvcviIl9oJAo/STUft+BFpbOhnfqDVF+r1bVvpt2xnbSxP1bLp8q fq/ycqMQyw/lZd828hqxH2mvtniyS6csf0n73dY50+2vevnH74hyOdc40yC28/LR/ANa8xX+ KbEUZyQaajEXFScCAO6DkfkTAgAA X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(3190300001)(189002)(24454002)(199003)(377454003)(106466001)(8676002)(2270400002)(36756003)(86362001)(50466002)(1691005)(5008740100001)(4001350100001)(5003600100002)(2906002)(8936002)(33646002)(97736004)(65956001)(5001770100001)(47776003)(65806001)(53416004)(68736007)(31696002)(69596002)(11100500001)(586003)(230700001)(31686004)(83506001)(4326007)(77096005)(81166006)(81156014)(87936001)(23746002)(6806005)(64126003)(2950100001)(92566002)(189998001)(54356999)(50986999)(76176999)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB528;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD007;1:/9Atm5ZpgxX/p+yjejlVFGqD2wwvPzc2T2wyQZRKEXAQgnlLwbnW94eXiVAxfqPUV/4V31g+QpVaopRMN82+d+JK3GqRVhwZOlOWLizJMcV8sVvljCMea+8ELq88kw0gf8+Ypa0zfBw5mxcepq7H98y4XzZNfh3e+z6uIpE5MGOvh18LwZcjER03oaM1oX/wUo5suanMFs4hFr6hmym1GQBsvVg0SqQyYAzwK+zmbJ+j+R+U/2+ov3yV0do6rc0AueT9AxbzOjZRntil6Q99IZvx08eh9e9w6kZtcol+x/giA5LVVBi0Xjd7R4fJQJbUPYhP/fs5Qxx6OlXjNAbPcU6pNaFFyWAbkKCOeDteN8Xyg5NASb+XpXrg+ge3LZxyOnlwEnqaiN7RU/NB7uLrsL+Sr1ukHsXeI5DyfibKs9kfkNDvJWOvc39i5LKA7fnc4Hb9ZtfioM5N55ZRJMjg92vpp04UMyihfgeoZ3kKXDmujLhWQextGLVViLIE74Ag57ZP7nZDIuq2yd6U7dXmQQ== X-MS-Office365-Filtering-Correlation-Id: 75246e14-cfbe-4827-cfeb-08d38f02202f X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB528;2:r2/a0a3F4yRxMFhTTV5juRZCRHdBC19gQUoPjauGjhGaBWBVyvIb7kb2KEWBRbi5djPb+g4JNy24GY+i9YYs+katIKW7JRAQ/p0ai5WHK+5THReEcCirbKk/0sPO0+2243lQNhBedAzEOr2nSL485uqdly/e90VDfkuDQLZoBUvOl42jVZ3fl+sMP6hPfLdv;3:OyaBZOyL2H6T7r6c/ZYjM4CpX6oQF/S51aforFNByjGCPJfpoXvz/siY2R/hfAMYcs/TnyhvZEoP3Ef72W3nbr+2fIHsIwYk2AeSCZgApiAueaqFsRYa2LUeJ8Cvvv15RCbASG8D+DSd5Lgr9CAoMTKTk/RLQKrNPBjB3X/w4eRMLzyPhBc8gm6n7uTTuLIayo28SHg5G8COZOte9naMZi+xm9sZaUN3OIozDLWT9qaUULmx8ykWOVzhLSr4qIY7PLgN/R5Xt9Ukd69b5RHs6A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DM2PR02MB528; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB528;25:TVadF2qAyZZTjNm1BcARrRkMLfGyT9bxfejaqA74JXUTw9ymKaygltEciKcpUdDXHg1sPOS852C9Gs8Jvd0plUILAHPGoyERBbJTAWtbbXrmjTuYRoVVgZYb0UUUhR+J9u8vMIdyi4xUkq65ewaDl40d862g+1NOexnAIz8vEg7WHiGWCiY0m0u7zopkPtvWHCLmdPmyvLZyM0oEBi/H4YB6MVHWfFTNl5Vh+3o/ac8jKHgAIptks6Zd/8DyiDpFH5X13gfOdMkVorfd+KEHM6jxKf5bK23uNIcXB3QY3XzGw8aLqYd0Tk7BWz534fIBka0LOjEpqQbPYMugsnkEXgqK21C++aNUYGHA/FS/tO0usk6cdOmMtvhjogK4T7DmqEt7WBPTOPzsvwJP1qd6TwLJb1b9zdwl2u0UHfdGd2ql0Ne7C75EVz1fXjj3mqTi3E5dtW06cGzBPkQy6v0EklUx0YTrd5kXmNJgB2/y8QH50eY1iTUKofug8nI4Qwv5F6xLOeqhDo06PBDSiVXnZ0q8LjwsoBfSXwOTgXVk2OQUH4wpM5YhYmRCiPdPN1E+1RtUwYVxEYgG61KUi5nLYUAgOrLhoqJKsR77ptQs8KJH6HEw3xOqVy3USJkrfkAaFzIKUUDSVB82ufNJ2TlVIEA8en2SMuvgclkuEpHyVuwn9DC+7Scn4dXwvAAJhoTIGdZppkbsFDwOHAdXkOe0fKvSIOILP0K6xcm9IddsuA8MW6iP3iXJRnWHQPTr6Jfs X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB528;20:GDCgX7gMhxYC40397g/l6yi/hkdh4mWrjeQXgMSj9bFuJ5MvqvRZmaddl2qKN7A61VeovYRtd92SlgFtguTj1dUuXnA2yZ+9Uk8HMScXYn/SkvrjYjlj3yJOcdPshfvDnZqkfwzrlQL9RzJlyAbPXSM0gGyLE+MN1FLXxKFhPaOu4DVu1nsMF8Nx881D+pq+yHdFPu+4qF+0mbzzv8gysMGBD0TMHfnPU2BYn0zi6A9oRqFFBanjdVtmUthxN4KdvnZcfXQ9gldf8Mrc3Xtf35VOt9Hb0xQCNCodaElp1tI+FUwemSL1MM1XkNNJl0tvcxEOB1569X6waNuBJM5haVoQUftPwF5bHFFug8a1yPqbLz+MF/sB/FnmId0/BS6cSgyjKcoOBYf1Siuinyo0hbf3M++Ijj6LSelCdP+i0dYAUYtys+fMavp1L+ekacb+pZssvz33M08wOIMmLTSlW2VvnWnzSL/yzky3XFqesoT+Cs7u7QXiP65HEYRXHIw+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13016025)(5005006)(13018025)(10201501046)(3002001)(6055026);SRVR:DM2PR02MB528;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB528; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB528;4:4Ac0SWJksbMD+S8+7faSvgwGCQThHrfHjyQBxzYRIDqBURAPoiaueKlIld6ph9XJOQR5UrO5hU7AtqBU2L3MnMcCLUAqOWyb+wEgbeeUWFiy7kWRgY8hJY1pIWi0KXV2NuD91X/wT0bVhu/+zRuNBRwjEOVan0Vt4nbyGl8j15z2XgdAYlNlIM55KiQ9yQRuYca82Po6xSH4xA5mhN2IQBj1tJntCfvaQYFKw1pkh5+UjTab+9cIQQ7rD2zJtlcP4xF6ULABjjRtKDa5LGA3VFIsZW3CHroQjbW1aFKtEbmrAmpW4t+Cb4ospkptdLs5adFO6b9RzuihpkCULvdhv53WJ4vDfF4fy2TLBlk71BuXE//+gwX42SdCE5pSFlCUuXKjC3NXtpcrEh71JvUuwqlXEIdmbL8Npc4Qk3RIyGfY0EsODHQcMsNJ1e2uPxBuIvhhNvcjDxookCmjzMMfC39aS0VkCmxAPPiL49WnRxY= X-Forefront-PRVS: 09669DB681 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR02MB528;23:Ky2CJIdsrJVC3q/meTxe9H7n4V/43T5Ou+2IzP?= =?Windows-1252?Q?B/bLpNzD3Y0MEpCVF42IcstGU4P3DSeXmTcjXkcIYEp/FoB1yFKkTdV0?= =?Windows-1252?Q?N/KZ7SH5QoUYlG3HJV9rUGN5h5z9vUf98nUaqIfY04ti5F7vCYXZd4p/?= =?Windows-1252?Q?rl/oW/aZY/Kzp26eclg1mYIs6z9YkVLFqUpY0tUVyH+1+UYDZBzqebom?= =?Windows-1252?Q?5yBzECZKUu+cq/JEydufht+zmgha4lhnZz1kQwIKHiuZiWRcORVB/SsS?= =?Windows-1252?Q?6ebTHCWdobBEgVw4+FT+L2K8KDNz3xg1G6NbzejkGTMrUx8Dbaqqh+1E?= =?Windows-1252?Q?bxW2rpPwdnAtkov4ciO0C3zhlS0MD+LyipPDxOrtTQORxh/Z2JQHQD+9?= =?Windows-1252?Q?H0QWAAvMtlRC9CepNOyM2RRbhBgOeeQ0ja3bCPWV0Fq1vT4dqcrhDnss?= =?Windows-1252?Q?yFDVx6APeDrURqIKqsKj3/z+hkjNGFkbtTcNgTrNMnf6D7WcIvGXgPzy?= =?Windows-1252?Q?w7/+xcmhrZFMwToVMgQvP4Bs8tizfl4tRHzGQkL7KW+x/pi2NV/MHdJU?= =?Windows-1252?Q?vEMk5IlvwcRdwOX9gv0eLnOifF+IS8ZO13mq8tj4qVXnnB9RUR2E/5kn?= =?Windows-1252?Q?vkxZi6fS5lXoto9GheJ5NK5CiGAmkpGEuk9uWKlvqVEHiGq/89Upcdpc?= =?Windows-1252?Q?YbgxUr2977IjgPTJRxyiew8zKkC99feHRI6g9QF5HDPwN0V4nxUZdoh5?= =?Windows-1252?Q?5+nlZ7Tnac8pibL/0UiTBNBwFVcfkNLrwyszjjNB0tJp8U0TxSVhkEYX?= =?Windows-1252?Q?VwCh9OlBv8vkY8SusZBK2GVn7UF7xXu33hOBJNrXx1Ed2EfLZeAKCtVY?= =?Windows-1252?Q?Ibul3EmQmfP04mUj6IK/v38H1UMGMHFwtQRk8owc2rBI68yZZ9JPYx/y?= =?Windows-1252?Q?h4izZo89X0hyPMgGMf8XxvDwInaS6n90MFakwU0c6hiPJaJtAmuVZqA6?= =?Windows-1252?Q?cFLT5Dlu8iqeATsjFaqVKG9iVLg8dziGHciE2fLkOnCFcLFtmKijM2/Z?= =?Windows-1252?Q?KflD8/0G9TWOXb2mUlg0WLHtu3qGXcMgRroGZvVKrLvFYc3CSk3UR5uY?= =?Windows-1252?Q?37P7r8KVV2SRylW93mKNgolIODYn4fe2yRE+1JVOFJxn/WOIqNgKZVK6?= =?Windows-1252?Q?z+/UENh7nBbsNAh3kTT8EzOTuR1fFqbyqA0Wn9Tc30JS7bnZZQab6Ubq?= =?Windows-1252?Q?egYr1yJLYqkmW1dqGgsxQH9y4sT2cTDbra6d2EuFn+blc/pI7DqcRRBF?= =?Windows-1252?Q?HZlH7u364HGTdZDrVm1YhoBcyBNrnXnxn+e9iumvTJzAhMlWkqMAF5Cv?= =?Windows-1252?Q?xEolhSojSP?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB528;5:7zRbeX5+YNtTRuCFxn+dx2/dTog9rRYcSdbUmdQgm/C2ztszW35uA8M64McBlo4/GWss78hAz6n0fm9VV3zOy+Dq32ZoZcIYdV0SF/cE5CTPIDBNEgJX0C+MZgwt1Eq/5PRflpdJQFWqFq2935qIEw==;24:R/h+wvISGvinky11nHv1/kDdXS+6YQHouWREGeqa33ljhsn9DUYF1l/fTG/AF9N8valMx6hMuM5wUPjSDdM6D8Gt0VDNmMcb/j53UfSU+bk=;7:FDj2CFNFiBiDVX7WLUB4wuV6x33Obd1bIahs+wMlf6PL52XLHF2qCyWoE9rr3oeBC/Kl2YNCjg6x0sfgcrd5dllydYykI/ixAEynh6PZ4qfLkFm0R9IBvxvMYCQv5WWwwmokbc9B1v4DRYJbM2HdxV7VjXWHOYqE4Pw7kVfYDK62cbMYhYtmPcb6tvdkdhFYDNtijLsOaW32oq9g0zKX28imILAyQg0WTus9LMPsvIU=;20:E2Th/GGcBd9V1uMRZx6p01AbFjK7lJKlrwVy+tEbqJD7DTfRA4CwoDUkEni9T51i36rwM0hkMkfR9mynKaLrK0FhC5m/WcL6e1/5yisEQMpY3Eyr2nN9CzsRl/IFqDHPzR2vEE1gjEqkgvTo18pSPJBaowdePv04VBj50WlQQZvUngjEpH6qxefqjPJq1N9dJz3NtKvqTonW+zRxGzEUxgksytXf2feeKI2AbsCrFDAj/cYL2qNQbyAPJU5f/FFt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2016 18:32:48.1614 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB528 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote: > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workqueue srp_remove_wq with > workitem &target->remove_work, is a work queue for the SRP target removal. > WQ_MEM_RECLAIM has been set to ensure forward progress under memory > pressure. > Since there are only a fixed number of work items, explicit > concurrency limit is unnecessary here. > > Is the workqueue being used on a memory reclaim path? > Does it require WQ_MEM_RECLAIM? Hello Bhaktipriya, srp_remove_wq is used for SRP target port removal work only. This work is neither queued from inside a shrinker nor by the page writeback code so I think it is safe to drop WQ_MEM_RECLAIM. Thanks, Bart.