From: Phi Nguyen <phind.uet@gmail.com>
To: Neal Cardwell <ncardwell@google.com>
Cc: edumazet@google.com, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kafai@fb.com, songliubraving@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+f1e24a0594d4e3a895d3@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized
Date: Sat, 3 Jul 2021 17:47:12 +0800 [thread overview]
Message-ID: <f3d57ece-8fc7-f0b1-a675-32cfcd64bdda@gmail.com> (raw)
In-Reply-To: <CADVnQynvWsD2qWfw4qJsNhyyPXbFGfhZmhMzaggfJ8JtUUt9VA@mail.gmail.com>
On 7/3/2021 4:31 AM, Neal Cardwell wrote:
> Please note that the patchwork tools have found a style/formatting
> issue with your Fixes tag:
>
> You can find them at:
> https://patchwork.kernel.org/project/netdevbpf/list/
> ->
> https://patchwork.kernel.org/project/netdevbpf/patch/20210702194033.1370634-1-phind.uet@gmail.com/
> ->
> https://patchwork.hopto.org/static/nipa/510221/12356435/verify_fixes/stdout
>
> The error is:
> ---
> Fixes tag: Fixes: commit 8919a9b31eb4 ("tcp: Only init congestion control if not
> Has these problem(s):
> - leading word 'commit' unexpected
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
> ---
>
> Basically, please omit the "commit" and don't wrap the text (it's OK
> if it's longer than 80 or 100 characters).
>
> thanks,
> neal
>
Hi,
I didn't even know there are patchwork tools for checking formatting.
Thank you for pointing out, I have just submitted a new version.
Best regards,
Phi.
prev parent reply other threads:[~2021-07-03 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 19:40 [PATCH v2] tcp: fix tcp_init_transfer() to not reset icsk_ca_initialized Nguyen Dinh Phi
2021-07-02 20:31 ` Neal Cardwell
2021-07-03 9:47 ` Phi Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3d57ece-8fc7-f0b1-a675-32cfcd64bdda@gmail.com \
--to=phind.uet@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=syzbot+f1e24a0594d4e3a895d3@syzkaller.appspotmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).