From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9887724B22; Fri, 15 Dec 2023 10:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="DX8WnWju" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702637856; bh=EI12yaPkWm0eHYHNIsLb+3ZJ50dk+sRbBa6SPm5COJE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DX8WnWjuyfGHxff/9Tu5FrQinxye03okq+4IAPtRo8geLH+OWPTx6vtkpZQ+bD8E4 QyubWDb3P9Uut8klFbQRPr5PE7xQgMH65E/gbdI4XIQmQs2bfY1PSnunJJ503VL02s u/55o3yYonOLRe5x+Ney1S4uHcCaZpIRyHee+iPcn4Wg2V2A8b5oGk2QzfzRrMVIa+ T2BKF2A8LgvKMLleyu6hkMY0yvarD1gK6OeKJEvMXBAuOzW8e/a1X0fhArLUiScrd1 CHkgwibHIJWnFSAA5XVpt46Mkq5swAODhAyrhCz2+klzF9igG5nRo1qPa0mfAQ+HrY UQfbDZsf0sBLA== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 4D9F83781FD5; Fri, 15 Dec 2023 10:57:35 +0000 (UTC) Message-ID: Date: Fri, 15 Dec 2023 12:57:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] ASoC: SOF: topology: Add new DAI type entry for SOF_DAI_AMD_BT Content-Language: en-US To: Venkata Prasad Potturu , Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Alper Nebi Yasak , Syed Saba Kareem , Kuninori Morimoto , Marian Postevca , Vijendar Mukunda , V sujith kumar Reddy , Mastan Katragadda , Ajit Kumar Pandey , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org, kernel@collabora.com References: <20231209205351.880797-1-cristian.ciocaltea@collabora.com> <20231209205351.880797-12-cristian.ciocaltea@collabora.com> <318470ce-1631-4c46-b425-755c877dda65@amd.com> <421128f7-6a17-4be9-a72b-272ea4017fbd@collabora.com> <5095ce7b-13bd-4805-b81e-f7565ab41b67@collabora.com> <0de8f81b-e7d4-43f6-b011-eb6ee09cc7fe@amd.com> <913257d4-75dc-4887-97d6-0f206c401057@collabora.com> <188ee32a-a201-4210-a8bc-bf3ba04e2f2b@amd.com> From: Cristian Ciocaltea In-Reply-To: <188ee32a-a201-4210-a8bc-bf3ba04e2f2b@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/15/23 11:58, Venkata Prasad Potturu wrote: > > On 12/14/23 22:12, Cristian Ciocaltea wrote: >> On 12/14/23 15:15, Venkata Prasad Potturu wrote: >>> On 12/14/23 17:53, Cristian Ciocaltea wrote: >>>> On 12/11/23 07:58, Venkata Prasad Potturu wrote: >>>>> On 12/10/23 21:20, Cristian Ciocaltea wrote: >>>>>> On 12/10/23 16:01, Mark Brown wrote: >>>>>>> On Sun, Dec 10, 2023 at 12:12:53PM +0200, Cristian Ciocaltea wrote: >>>>>>>> On 12/10/23 11:51, Venkata Prasad Potturu wrote: >>>>>>>>> This should send to SOF git repo for rewiew, once SOF reviewers >>>>>>>>> approved >>>>>>>>> this, again need to send to broonie git. >>>>>>>>> All the changes in sound/soc/sof/ path should go to SOF git. >>>>>>>> Unfortunately I'm not familiar with the SOF dev workflow. So >>>>>>>> it's not >>>>>>>> enough to have this patch cc-ed to >>>>>>>> sound-open-firmware@alsa-project.org? >>>>>>> The SOF people basically do their own thing in github at >>>>>>> >>>>>>>       https://github.com/thesofproject/linux >>>>>>> >>>>>>> with a github workflow and submit their patches upstream in >>>>>>> batches a >>>>>>> few times a release, however my understanding is that their >>>>>>> workflow can >>>>>>> cope with things going in directly upstream as well. >>>>>> Thanks for clarifying, Mark!  That would greatly simplify and speedup >>>>>> the whole process, at least for trivial patches like this one. >>>>> Hi Cristian, >>>>> >>>>> We have created a Pull request in SOF git hub for I2S BT support. >>>>> please hold v2 version SOF patches till below PR get's merged. >>>>> PR:- https://github.com/thesofproject/linux/pull/4742 >>>> Hi Venkata, >>>> >>>> If this is going to be handled via the github workflow, this patch >>>> should be removed from the series.  Since there is no dependency on it, >>>> I cannot see a reason to put v2 on hold. >>>> >>>> Do I miss something? >>> Non-sof driver related patches can directly send to broonie git ad v2 >>> series. >>> SOF driver patches should send to SOF github to avoid merge conflicts >>> as  per guidelines of SOF community. >> Honestly, I don't really see a high risk of conflicts, the patches are >> not that complex and can be simply cherry-picked when needed.  Moreover, >> as we already had people reviewing this, splitting this up will only add >> confusion and unnecessary burden. >> >> Are there any specific changes you are concerned about and cannot be >> really handled here? > This is not the concern about this patch series, > Generally sof driver patches sends to SOF git hub as a PR, these are the > guidelines by SOF maintainers. > If you still want to send alsa devel list directly, please discuss with > SOF maintainers. I think this series makes sense as a whole and it's best to be handled here, as it only provides trivial fixes to issues found on mainline. If the SOF workflow is unable to integrate fixes submitted upstream, I would perceive that as a significant drawback of adhering to that process. It is hard to believe, though, that this is really the case. Hence, I kindly ask everyone here to shed some light and help move this forward. Thank you, Cristian