From: Stefan Roese <sr@denx.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bin Meng <bmeng.cn@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH
Date: Fri, 25 Aug 2017 14:12:58 +0200 [thread overview]
Message-ID: <f3f0cbaf-aece-6e55-cfc6-884788ae3f8a@denx.de> (raw)
In-Reply-To: <20170825104015.GB2980@lahna.fi.intel.com>
On 25.08.2017 12:40, Mika Westerberg wrote:
> On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote:
>> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
>> data. Select it in the Kconfig.
>>
>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>
>> drivers/mtd/spi-nor/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
>> index bfdfb1e..e998800 100644
>> --- a/drivers/mtd/spi-nor/Kconfig
>> +++ b/drivers/mtd/spi-nor/Kconfig
>> @@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM
>> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
>> depends on X86
>> select SPI_INTEL_SPI
>> + select LPC_ICH
>
> How about
>
> depends on X86 && LPC_ICH
>
> instead?
I prefer Bin's version, as with your patch, the MTD SPI driver will
not be "seen" / selectable, as long as the LPC_ICH support is not
enabled. I've been hunting such dependencies myself a few times and
find them unnecessary burden.
Thanks,
Stefan
next prev parent reply other threads:[~2017-08-25 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 8:12 [PATCH] spi-nor: intel-spi: Fix Kconfig dependency to LPC_ICH Bin Meng
2017-08-25 10:40 ` Mika Westerberg
2017-08-25 12:11 ` Bin Meng
2017-08-27 14:44 ` Mika Westerberg
2017-08-25 12:12 ` Stefan Roese [this message]
2017-10-11 8:03 ` Cyrille Pitchen
2017-10-13 11:15 ` Arnd Bergmann
2017-10-14 6:09 ` Cyrille Pitchen
2017-10-15 13:38 ` Bin Meng
2017-10-16 12:34 ` Arnd Bergmann
2017-10-23 12:12 ` Mika Westerberg
2017-10-24 7:08 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f0cbaf-aece-6e55-cfc6-884788ae3f8a@denx.de \
--to=sr@denx.de \
--cc=bmeng.cn@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).