From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdEBDw7 (ORCPT ); Mon, 1 May 2017 23:52:59 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:61127 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750847AbdEBDw5 (ORCPT ); Mon, 1 May 2017 23:52:57 -0400 Subject: Re: [PATCH 2/3] ti-soc-thermal: Delete error messages for failed memory allocations in ti_bandgap_build() To: SF Markus Elfring , , , Eduardo Valentin , Zhang Rui References: <65329026-ad0d-df20-1ff6-4befab001b3c@users.sourceforge.net> CC: LKML , , Wolfram Sang From: Keerthy Message-ID: Date: Tue, 2 May 2017 09:22:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <65329026-ad0d-df20-1ff6-4befab001b3c@users.sourceforge.net> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 26 April 2017 09:07 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 26 Apr 2017 17:03:07 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: Possible unnecessary 'out of memory' message > > Thus remove such statements here. Reviewed-by: Keerthy > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring > --- > drivers/thermal/ti-soc-thermal/ti-bandgap.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > index f19cb7612a65..109fb0a5f19f 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c > +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c > @@ -1217,7 +1217,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev) > - if (!bgp) { > - dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n"); > + if (!bgp) > return ERR_PTR(-ENOMEM); > - } > > of_id = of_match_device(of_ti_bandgap_match, &pdev->dev); > if (of_id) > @@ -1229,7 +1227,5 @@ static struct ti_bandgap *ti_bandgap_build(struct platform_device *pdev) > - if (!bgp->regval) { > - dev_err(&pdev->dev, "Unable to allocate mem for driver ref\n"); > + if (!bgp->regval) > return ERR_PTR(-ENOMEM); > - } > > i = 0; > do { >