From: John Crispin <john@phrozen.org>
To: "André Valentin" <avalentin@marcant.net>,
"Marek Vasut" <marek.vasut@gmail.com>,
"Cyrille Pitchen" <cyrille.pitchen@atmel.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f
Date: Wed, 21 Dec 2016 09:18:49 +0100 [thread overview]
Message-ID: <f4131e48-a972-921a-3d3e-0d7514b229b7@phrozen.org> (raw)
In-Reply-To: <44b8e7db-e928-d982-3fb7-5dd39ee9844c@marcant.net>
Hi André
could you test if it also works when enabling SECT_4K please ?
John
On 21/12/2016 09:11, André Valentin wrote:
> Hi!
>
> I took these values from the manufacturer SDK (Qualcomm). I could not detect any problems with the setting.
>
> Kind regards,
>
> André
>
> Am 21.12.2016 um 08:33 schrieb Marek Vasut:
>> On 12/21/2016 08:23 AM, John Crispin wrote:
>>> From: André Valentin <avalentin@marcant.net>
>>>
>>> This patch adds support for a new macronix spi flash chip. We have had this
>>> patch inside our tree for a while and people are actively using routers
>>> with this chip.
>>>
>>> Signed-off-by: John Crispin <john@phrozen.org>
>>> Signed-off-by: André Valentin <avalentin@marcant.net>
>>> ---
>>> Changes in V2
>>> * add description
>>> * add SECT_4K
>>> * fix indenting
>>
>> Are you SURE this chip can do sect_4k ? The datasheet seems to imply
>> that, but I wonder why it wasn't in V1 of this patch then ? Esp. if
>> people are actively using this chip ...
>>
>>> drivers/mtd/spi-nor/spi-nor.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
>>> index 171adb3..bfff159 100644
>>> --- a/drivers/mtd/spi-nor/spi-nor.c
>>> +++ b/drivers/mtd/spi-nor/spi-nor.c
>>> @@ -868,6 +868,7 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len)
>>> { "mx25l3205d", INFO(0xc22016, 0, 64 * 1024, 64, SECT_4K) },
>>> { "mx25l3255e", INFO(0xc29e16, 0, 64 * 1024, 64, SECT_4K) },
>>> { "mx25l6405d", INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>>> + { "mx25u3235f", INFO(0xc22536, 0, 64 * 1024, 64, SECT_4K) },
>>> { "mx25u6435f", INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
>>> { "mx25l12805d", INFO(0xc22018, 0, 64 * 1024, 256, 0) },
>>> { "mx25l12855e", INFO(0xc22618, 0, 64 * 1024, 256, 0) },
>>>
>>
>>
>
next prev parent reply other threads:[~2016-12-21 8:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 7:23 [PATCH V2 0/3] mtd: spi-nor: add some new chip ids John Crispin
2016-12-21 7:23 ` [PATCH V2 1/3] mtd: spi-nor: add support for macronix mx25u25635f John Crispin
2016-12-21 7:32 ` Marek Vasut
2016-12-21 10:41 ` Cyrille Pitchen
2016-12-21 7:23 ` [PATCH V2 2/3] mtd: spi-nor: add support for macronix mx25u3235f John Crispin
2016-12-21 7:33 ` Marek Vasut
2016-12-21 7:36 ` John Crispin
2016-12-21 8:11 ` André Valentin
2016-12-21 8:18 ` John Crispin [this message]
2016-12-21 10:07 ` Marek Vasut
2016-12-21 10:13 ` John Crispin
2016-12-21 10:27 ` Cyrille Pitchen
2016-12-21 13:16 ` John Crispin
2016-12-21 13:38 ` Cyrille Pitchen
2016-12-21 7:23 ` [PATCH V2 3/3] mtd: spi-nor: add support for ESMT_f25l32qa and ESMT_f25l64qa John Crispin
2017-01-30 13:04 ` Cyrille Pitchen
2017-02-14 11:49 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4131e48-a972-921a-3d3e-0d7514b229b7@phrozen.org \
--to=john@phrozen.org \
--cc=avalentin@marcant.net \
--cc=cyrille.pitchen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).