From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758997AbcIWLHp (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Sep 2016 07:07:45 -0400
Received: from mout.web.de ([212.227.17.11]:57624 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1758196AbcIWLHm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Sep 2016 07:07:42 -0400
Subject: Re: GPU-DRM-TTM: Fine-tuning for several function implementations
To: =?UTF-8?Q?Christian_K=c3=b6nig?= <deathsimple@vodafone.de>
References: <566ABCD9.1060404@users.sourceforge.net>
 <4d34446f-05ad-c3ce-5d33-8fb4f25af25c@users.sourceforge.net>
 <f079ffc1-042c-0332-98e1-5acc6589e4b6@vodafone.de>
 <05418fb1-ad66-aba3-bd8c-f6b684a83279@users.sourceforge.net>
 <f0172ebe-9036-0e11-42c8-1e1230b01e5c@vodafone.de>
Cc: dri-devel@lists.freedesktop.org,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        Julia Lawall <julia.lawall@lip6.fr>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f41a2f39-1d7d-9f40-92e5-66728ed126eb@users.sourceforge.net>
Date: Fri, 23 Sep 2016 13:07:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <f0172ebe-9036-0e11-42c8-1e1230b01e5c@vodafone.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:atvu0yaX1Ba+LmhpmxW/yCrND1bTvNgoHkAkOCVGX0LBHJBvWA7
 QTX+bg4xthPklE0hNGVXl/4PxJdJK+7YwtfBDxS5ea3DI2Yr4JJsdH3k/oG0kTnQDoLkbx9
 7qpk0JprMV+OfdQnOz8Ak7F7X5m5lypP56SJy59wsSLQ4NApwi4WMa/KmVp/EcOqxoIRyQz
 eQNstBgsyjF7AGW/jAYcA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:XT0+GALtbzQ=:TPstmXXBMS31Wo6QcDc9Uv
 HQgTouF+yXfsZ+q4/Ebo1xjinHELUpNBWpxrM3vvDjThCB0gKYzUxvs8bzHkgBTaBpdzj5ix9
 SGEdBRhWlHKVRJLy9zwQxSuf2a+XJc83ZElptEH6BS3rsqwPtDkQw4fGH6yOIXueYgMB4f/xt
 nXedynglv1mEVrZgCwGcBG0+enoHwTTmSo1m0PhRma3j+9R3bTetGi3r/vGkMC5kd/wj+PE9E
 kURrLsWMxzlzkL+Xrpz5i2gD4QT6YQrZ/uPuzvrsOXMYlRsyhlvqCayuI+zEWXa2Zc0uYoZRB
 NGvQP0c181qW8ldkzxzet9eX0BJtk4+pkRx0ZKEJdWCBYBR1awJDevkFlph7imv6e0K6sbl4v
 sYCH1DSHdHoMy/NRnONyj42uZ3jaNKiueT2cU8aA7FmgN+vqO1nAe5VJuI1EZG+bH26Kxkhb4
 4WwbcVeiQ5hwGVgs/TVp/lTJgOzdv+WSYTdmlzkhZblkysc2RFK49UPE77s/hw/ewHaZ7c2ao
 r27rPDJK8pHHv+NSERgS5HWO1qHseCddbQ0Co3D4yFNUZ/weLShOJDrI7syc6WQJj/CwxgkRi
 4ERz/RbhBQgnLFwp6CikFnZ7agNpEAWwjXW1ktgo0FfLGBAxaLDQheoXqFkd4Hfe7lK16vXTY
 RJBo7uv9yoxKIT+65a2dQm1oJMcL2mUV46+FXZ4GbgeKa8VF8UGeXqGc2fvFu/uxOk2vXt9ZS
 IacibAgTgfRCDNlUM08DPi0zH+8J6Lnpm3IbSXzOmpMQ4ly3iuy7HkRvSHqLLDV0GXgOO+8dK
 qfdvKIx
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> It's just the names like "out" or "restart" perfectly explain why the labels exists.

I have got an other impression.


> So they fulfill this requirement from the coding style as far as I can see.

Short identifiers might look more convenient in some cases because
they are quicker to type.


> So why do you want to change them?

1. I suggest to select identifiers also for jump labels which are more meaningful
   and eventually unique for some function implementations.

2. How do you think about to add a single space character before any label?

Regards,
Markus