LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Stephen Boyd <sboyd@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: <linux-clk@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock
Date: Sat, 15 Feb 2020 18:07:34 +0530
Message-ID: <f42d90ca-0078-7ae4-c9b1-a9d23dd251e3@ti.com> (raw)
In-Reply-To: <158136034652.94449.4389789192412792346@swboyd.mtv.corp.google.com>

Hi,

On 2/11/2020 12:15 AM, Stephen Boyd wrote:
> Quoting Vignesh Raghavendra (2020-02-06 20:44:24)
[...]
>> +  - Vignesh Raghavendra <vigneshr@ti.com>
>> +
>> +description: |
>> +
>> +  This binding uses common clock bindings
>> +  Documentation/devicetree/bindings/clock/clock-bindings.txt
> 
> Maybe have a real description instead of this line which is mostly
> useless.
> 

Will drop this line..

>> +
>> +properties:
>> +  compatible:
>> +    items:
> 
> I think you can drop items.
> 
>> +      - const: ti,am654-ehrpwm-tbclk
>> +
>> +  "#clock-cells":
>> +    const: 1
>> +
>> +  ti,tbclk-syscon:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description:
>> +      Phandle to the system controller node that has bits to
>> +      control eHRPWM's TBCLK
>> +
>> +required:
>> +  - compatible
>> +  - "#clock-cells"
>> +  - ti,tbclk-syscon
>> +
>> +examples:
>> +  - |
>> +    tbclk_ctrl: tbclk_ctrl@4140 {
>> +        compatible = "syscon";
>> +        reg = <0x4140 0x18>;
>> +    };
>> +
>> +    ehrpwm_tbclk: clk0 {
>> +        compatible = "ti,am654-ehrpwm-tbclk";
>> +        #clock-cells = <1>;
>> +        ti,tbclk-syscon = <&tbclk_ctrl>;
>> +    };
> 
> I don't understand the binding. Why can't the syscon node register clks
> and have #clock-cells?
> 

I did not know that would work. Will make syscon code to register clks..
Thanks!

Regards
Vignesh

  reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  4:44 [PATCH v2 0/2] clk: keystone: Add new driver to handle ehrpwm tbclk Vignesh Raghavendra
2020-02-07  4:44 ` [PATCH v2 1/2] dt-bindings: clock: Add binding documentation for TI syscon gate clock Vignesh Raghavendra
2020-02-10 18:45   ` Stephen Boyd
2020-02-15 12:37     ` Vignesh Raghavendra [this message]
2020-02-07  4:44 ` [PATCH v2 2/2] clk: keystone: Add new driver to handle syscon based clocks Vignesh Raghavendra
2020-02-10 18:59   ` Stephen Boyd
2020-02-15 12:42     ` Vignesh Raghavendra

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f42d90ca-0078-7ae4-c9b1-a9d23dd251e3@ti.com \
    --to=vigneshr@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git