From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932204AbdAJWPM (ORCPT ); Tue, 10 Jan 2017 17:15:12 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36581 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbdAJWPJ (ORCPT ); Tue, 10 Jan 2017 17:15:09 -0500 Subject: Re: [PATCH net-next 6/8] net: dsa: Add support for platform data To: Andrew Lunn , John Crispin References: <20170110201235.21771-1-f.fainelli@gmail.com> <20170110201235.21771-7-f.fainelli@gmail.com> <20170110204124.GL22820@lunn.ch> <1530c7f6-f8ba-ab32-75aa-288549f25db9@gmail.com> <20170110212117.GO22820@lunn.ch> Cc: netdev@vger.kernel.org, Jason Cooper , Sebastian Hesselbarth , Gregory Clement , Russell King , Vivien Didelot , "David S. Miller" , Philippe Reynes , Martin Schwidefsky , Greg Kroah-Hartman , Stuart Yoder , Ingo Tuchscherer , "moderated list:ARM/Marvell Dove/MV78xx0/Orion SOC support" , open list From: Florian Fainelli Message-ID: Date: Tue, 10 Jan 2017 14:15:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170110212117.GO22820@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2017 01:21 PM, Andrew Lunn wrote: >> Last time we discussed this, I had a super complex dsa2_platform_data >> that allowed you to do exactly the same thing we currently do with >> Device Tree, except that this was with platform_data. It took a lot of >> effort to get there, but I essentially had the ZII vf160 board example >> re-implemented and verified with a mockup driver (still have it in a >> branch that's not too far from net-next/master). > > One thing different this time is you have associated the platform data > to an MDIO device. So the platform data represents one switch, not the > whole complex. This is going to make the platform data much simpler, > and allow the core to do the work of assembling the multiple platform > datas into one switch complex. So basically, the platform data is > dsa_chip_data. > > To handle multi-CPUs, we need to move the master ethernet device and > put it next to the cpu port. So add a > > struct device *netdev[DSA_MAX_PORTS]; > > to dsa_chip_data. It then becomes easy to represent multiple CPU > ports. Alright, let me get that prepared then, thanks! > >> I would very much like to see the patches and then make a decision based >> on the submission rather than project a decision on code that has not >> been submitted yet. > > The first version was posted a week ago. I requested a lot of > changes. So lets see what John says about when the next version will > be ready. Oh that series, okay, somehow I thought you were referring to something else. -- Florian